docs: consistently name Consul service mesh #17222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove outdated usage of "Consul Connect" instead of Consul service mesh. The connect subsystem in Consul provides Consul's service mesh capabilities. However, the term "Consul Connect" should not be used as an alternative to the name "Consul service mesh".
| @@ -34,8 +35,8 @@ Usage: consul connect ca <subcommand> [options] [args] | |||
| For more examples, ask for subcommand help or view the documentation. | |||
|
|
|||
| Subcommands: | |||
| get-config Display the current Connect Certificate Authority (CA) configuration | |||
| set-config Modify the current Connect CA configuration | |||
| get-config Display the current service mesh Certificate Authority (CA) configuration | |||
There was a problem hiding this comment.
Note: I intend to submit a separate PR to change the CLI command help descriptions output by the code itself
There was a problem hiding this comment.
let's coordinate this with the TWs
There was a problem hiding this comment.
CLI help text update PR submitted for review by eng: #17230
david-yu
approved these changes
May 5, 2023
im2nguyen
approved these changes
May 5, 2023
| @@ -34,8 +35,8 @@ Usage: consul connect ca <subcommand> [options] [args] | |||
| For more examples, ask for subcommand help or view the documentation. | |||
|
|
|||
| Subcommands: | |||
| get-config Display the current Connect Certificate Authority (CA) configuration | |||
| set-config Modify the current Connect CA configuration | |||
| get-config Display the current service mesh Certificate Authority (CA) configuration | |||
There was a problem hiding this comment.
let's coordinate this with the TWs
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
2 tasks
jkirschner-hashicorp
added a commit
that referenced
this pull request
May 5, 2023
Remove outdated usage of "Consul Connect" instead of Consul service mesh. The connect subsystem in Consul provides Consul's service mesh capabilities. However, the term "Consul Connect" should not be used as an alternative to the name "Consul service mesh".
This was referenced May 5, 2023
jkirschner-hashicorp
added a commit
that referenced
this pull request
May 5, 2023
Remove outdated usage of "Consul Connect" instead of Consul service mesh. The connect subsystem in Consul provides Consul's service mesh capabilities. However, the term "Consul Connect" should not be used as an alternative to the name "Consul service mesh".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove outdated usage of "Consul Connect" instead of Consul service mesh.
The connect subsystem in Consul provides Consul's service mesh capabilities. However, the term "Consul Connect" should not be used as an alternative to the name "Consul service mesh".
Post PR Follow-Up