Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Test: add noCleanup to TestServer stop into release/1.15.x #16930

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16919 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

noCleanup exists in the test code to preserve the data after unit test run.

var noCleanup = strings.ToLower(os.Getenv("TEST_NOCLEANUP")) == "true"

noCleanup has been used in someplace like

func TempDir(t testing.TB, name string) string {

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/Upgrade-test-keep-unit-test-data/supposedly-comic-antelope branch from ec3df4f to de27093 Compare April 8, 2023 00:48
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) April 8, 2023 00:48
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/Upgrade-test-keep-unit-test-data/supposedly-comic-antelope branch from ace0e0b to 59e2f6c Compare April 8, 2023 00:48
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 43ee53a into release/1.15.x Apr 8, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/Upgrade-test-keep-unit-test-data/supposedly-comic-antelope branch April 8, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants