Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of [NET-3029] Migrate build-distros to GHA into release/1.15.x #16718

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Backport of [NET-3029] Migrate build-distros to GHA into release/1.15.x #16718

merged 2 commits into from
Mar 21, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16669 to be assessed for backporting due to the inclusion of the label backport/1.15.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: unable to process merge commit: "61164bf2b226baad9a4ec65e602418652adb89c3", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.

Signed-off-by: Dan Bond danbond@protonmail.com

Description

This PR introduces a new build-distros GitHub Actions workflow that is intended to replace the CircleCI equivalent. It is aimed at checking new commits don't introduce any breaking build changes.

The matrix is as follows:

  • 386: freebsd, linux, windows
  • amd64: darwin, freebsd, linux, solaris, windows
  • arm: linux

Notes

  • It does not build UI changes as there is already a separate PR job for that, and it is also covered as part of the CRT pipelines.
  • The existing CircleCI jobs will be removed in a separate PR.
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/loshz/NET-3029-build-distros/loudly-pro-airedale branch from 55b1037 to fa8a7c5 Compare March 21, 2023 17:38
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Mar 21, 2023
@jmurret jmurret marked this pull request as ready for review March 21, 2023 18:43
@jmurret jmurret requested a review from a team March 21, 2023 18:43
@jmurret jmurret requested a review from a team as a code owner March 21, 2023 18:43
@jmurret jmurret requested review from modrake and jeanneryan and removed request for a team March 21, 2023 18:43
loshz added 2 commits March 21, 2023 12:53
@loshz @jmurret
backport of commit bc70de1
18f8654
@loshz @jmurret
Manually fix build.yml bug
8713102 
Signed-off-by: Dan Bond <danbond@protonmail.com>
@jmurret jmurret force-pushed the backport/loshz/NET-3029-build-distros/loudly-pro-airedale branch from 0b1409e to 8713102 Compare March 21, 2023 18:53
@loshz loshz merged commit 16a1976 into release/1.15.x Mar 21, 2023
@loshz loshz deleted the backport/loshz/NET-3029-build-distros/loudly-pro-airedale branch March 21, 2023 22:22
This was referenced Mar 21, 2023
Closed
Merged
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@loshz loshz Awaiting requested review from loshz

@modrake modrake Awaiting requested review from modrake

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

Assignees
No one assigned
Labels
theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @loshz