Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix: add AccessorID property to PUT token request into release/1.15.x #16662

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16660 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

Triggering saving of token responds with 'Token Accessor ID in URL and payload do not match' error.
The reason is the AccessorID property has not been included to requestBody. there might be some changes on backend side, which updated requestBody structure to include AccessorID for token PUT endpoint.

Testing & Reproduction steps

Screen.Recording.2023-03-16.at.3.40.58.PM.mov

Testing & Reproduction steps

  • run make ui-docker to build the ui image
  • run make dev-docker
  • clone https://github.com/WenInCode/consul-setup
  • in the consul-setup repo go to the setups/peering directory
  • run docker-compose up
  • run yarn setup:peerings
  • Go to the token details page and press 'Save' button

Links

https://hashicorp.atlassian.net/browse/CC-4515

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/fix/update-token-request/virtually-immune-ewe branch 2 times, most recently from dc701b5 to 622742d Compare March 17, 2023 01:58
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) March 17, 2023 01:58
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/ui Anything related to the UI label Mar 17, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit bc111cb into release/1.15.x Mar 17, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/ui/fix/update-token-request/virtually-immune-ewe branch March 17, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants