Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of UI: Fix htmlsafe errors throughout the app into release/1.15.x #16591

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Backport of UI: Fix htmlsafe errors throughout the app into release/1.15.x #16591

merged 3 commits into from
Mar 16, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16574 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.

Description

Traced isHTMLSafe errors back to ember-intl package. There was minor release that addressed these issues. Unfortunately, this missed the patch Consul release.

Before
Screenshot 2023-03-08 at 10 25 09 AM

After:
Screenshot 2023-03-08 at 12 03 28 PM

Testing & Reproduction steps

  1. Checkout 1.15.1 branch
  2. run make ui-docker to build the ui image
  3. run make dev-docker
  4. clone https://github.com/WenInCode/consul-setup
  5. in the consul-setup repo go to the setups/peering directory
  6. run docker-compose up
  7. run yarn setup:peerings
  8. Go to the overview page or any page with an empty state

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/fix/upgrade-ember-intl/lively-living-wolf branch from 6641bca to ccd9a5f Compare March 9, 2023 19:43
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) March 9, 2023 19:44
@github-actions github-actions bot added the theme/ui Anything related to the UI label Mar 9, 2023
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@WenInCode WenInCode force-pushed the backport/ui/fix/upgrade-ember-intl/lively-living-wolf branch from ccd9a5f to e1169fc Compare March 16, 2023 23:08
@hc-github-team-consul-core hc-github-team-consul-core merged commit 283aa59 into release/1.15.x Mar 16, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/ui/fix/upgrade-ember-intl/lively-living-wolf branch March 16, 2023 23:21
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@WenInCode WenInCode Awaiting requested review from WenInCode

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver