Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: First pass at writing some data layer related Eng docs #11203

Merged
merged 1 commit into from
Jan 12, 2022
Merged

ui: First pass at writing some data layer related Eng docs #11203

merged 1 commit into from
Jan 12, 2022

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Oct 1, 2021 •
edited
Loading

First pass at adding some more generic Eng UI documentation for other folks working on the project. Specifically looking for feedback/questions from both folks who are familiar with this layer and folks who aren't.

Preview link

I added consul-ui as reviewer here, I think that covers everyone who would find this useful?

@johncowen johncowen added type/docs Documentation needs to be created/updated/clarified theme/ui Anything related to the UI labels Oct 1, 2021
@johncowen johncowen requested a review from a team October 1, 2021 15:41
@github-actions github-actions bot removed the type/docs Documentation needs to be created/updated/clarified label Oct 1, 2021
@johncowen johncowen added the pr/no-changelog PR does not need a corresponding .changelog entry label Oct 1, 2021
@luci237
Copy link

luci237 commented Oct 2, 2021

framework/src/test/java/org/tron/common/runtime/vm/ValidateMultiSignContractTest.java

@johncowen johncowen force-pushed the ui/chore/data-layer-docs branch from 8a7819d to 8612ad1 Compare October 4, 2021 09:39
@vercel vercel bot temporarily deployed to Preview – consul October 4, 2021 09:39 Inactive
@johncowen johncowen mentioned this pull request Oct 8, 2021
Merged
@johncowen johncowen requested review from evrowe and kaxcode October 13, 2021 10:33
@johncowen
Copy link
Contributor Author

Added some folks individually as reviewers here as I'm not sure the group thing pinged folks.

@amyrlam amyrlam self-requested a review January 7, 2022 18:40
@johncowen johncowen requested review from natmegs, a user and jgwhite January 7, 2022 18:43
amyrlam
amyrlam approved these changes Jan 12, 2022
View reviewed changes
Copy link

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 found this useful as I gain more context on Consul

@johncowen johncowen merged commit 2aaa96b into main Jan 12, 2022
@johncowen johncowen deleted the ui/chore/data-layer-docs branch January 12, 2022 09:26
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/549687.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyrlam amyrlam amyrlam approved these changes

@evrowe evrowe Awaiting requested review from evrowe

@kaxcode kaxcode Awaiting requested review from kaxcode

@natmegs natmegs Awaiting requested review from natmegs

@jgwhite jgwhite Awaiting requested review from jgwhite

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johncowen @luci237 @hc-github-team-consul-core @amyrlam