Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you're using -config-dir an empty .json file in there is bad news. #1661

Closed
darron opened this issue Jan 28, 2016 · 4 comments
Closed

If you're using -config-dir an empty .json file in there is bad news. #1661

darron opened this issue Jan 28, 2016 · 4 comments
Labels
type/bug Feature does not function as expected

Comments

@darron
Copy link
Contributor

darron commented Jan 28, 2016

I remember finding this a long time ago but I forgot to register it as a bug. Was talking with @slackpad last week and remembered.

I ran into it when a service that was writing config files failed and wrote a blank file into the folder - Consul then fails to start up - tries to parse and craps out.

Example output here:

https://gist.github.com/darron/7275837c7734041c5a4a

Not sure if it's something y'all can fix - guard against - but if it's possible that would likely be pretty awesome.

Thanks for the great software!

@slackpad slackpad added the type/bug Feature does not function as expected label Feb 2, 2016
alistanis pushed a commit to alistanis/consul that referenced this issue Feb 9, 2016
@MrMMorris
Copy link

This is kind of related to #1221 as well. Empty files causing issues.

slackpad added a commit that referenced this issue Feb 17, 2016
fixes issue #1661 and adds supporting test
@slackpad
Copy link
Contributor

Fixed in #1703.

@MrMMorris I think #1221 is a different issue where we are truncating on the write side.

@darron
Copy link
Contributor Author

darron commented Feb 17, 2016

Thanks for fixing this @slackpad and @alistanis - appreciate that!

@alistanis
Copy link

No problem @darron! Thanks for merging it @slackpad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Feature does not function as expected
Projects
None yet
Development

No branches or pull requests

4 participants