httproute hittable

hashicorp · Feb 22, 2023 · cc213b6 · cc213b6
1 parent 184b6bb
commit cc213b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/test/integration/consul-container/test/gateways/gateway_endpoint_test.go b/test/integration/consul-container/test/gateways/gateway_endpoint_test.go
@@ -152,18 +152,13 @@ func createService(t *testing.T, cluster *libcluster.Cluster, serviceOpts *libse
 	// Create a service and proxy instance
 
 	// Create a service and proxy instance
-	_, _, err := libservice.CreateAndRegisterStaticServerAndSidecar(node, serviceOpts)
-	require.NoError(t, err)
+	service, _, err := libservice.CreateAndRegisterStaticServerAndSidecar(node, serviceOpts)
+	assert.NoError(t, err)
 
 	libassert.CatalogServiceExists(t, client, serviceOpts.Name+"-sidecar-proxy")
 	libassert.CatalogServiceExists(t, client, serviceOpts.Name)
 
-	// Create a client proxy instance with the server as an upstream
-	//TODO this is always going to be named static-client-sidecar-proxy and I don't know if that matters
-	clientConnectProxy, err := libservice.CreateAndRegisterStaticClientSidecar(node, "", false)
-	require.NoError(t, err)
-	libassert.CatalogServiceExists(t, client, "static-client-sidecar-proxy")
-	return clientConnectProxy
+	return service
 
 }
 func createServices(t *testing.T, cluster *libcluster.Cluster, ports ...int) (libservice.Service, libservice.Service) {

diff --git a/test/integration/consul-container/test/gateways/http_route_test.go b/test/integration/consul-container/test/gateways/http_route_test.go
@@ -211,9 +211,6 @@ func TestHTTPRouteFlattening(t *testing.T) {
 		"x-v2": "v2",
 	})
 
-	for {
-	}
-
 	//libassert.HTTPServiceEchoes(t, "localhost", gatewayService.GetPort(listenerPort), "v2")
 	//checkRoute(t,
 	//	gatewayService.GetPort(listenerPort),