Merge ed9709a into backport/gh-19720-empty-server-metadata/implicitly…

…-apt-vulture
hashicorp · Jan 5, 2024 · 9ddeb0e · 9ddeb0e
2 parents 3b98692 + ed9709a
commit 9ddeb0e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/agent/agent.go b/agent/agent.go
@@ -4570,12 +4570,15 @@ func (a *Agent) persistServerMetadata() {
 				continue
 			}
 
-			sf := f.(*safeio.File)
-			if err := sf.Commit(); err != nil {
-				a.logger.Error("failed to commit server metadata", "error", err)
-				continue
+			// Use safeio.File to ensure the file is written to disk atomically
+			if sf, ok := f.(*safeio.File); ok {
+				if err := sf.Commit(); err != nil {
+					sf.Close()
+					a.logger.Error("failed to commit server metadata", "error", err)
+					continue
+				}
 			}
-			sf.Close()
+			f.Close()
 		case <-a.shutdownCh:
 			return
 		}