Register all kubernetes services to the k8s-sync node
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering the services with their node information causes issues with anti-entropy on the clients because they are registered directly with the servers rather than the clients. So, the clients don't have a record of the service and deregister them. This causes a register/deregister loop because the sync process automatically re-registers them. Given that the sync doesn't register things directly to the clients, it is more correct to register them to a synthetic node (`k8s-sync` in this case) to indicate that they don't follow the usual path.
|
Yes, this should fix the agents deregistering Kubernetes services. |
This was referenced Feb 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering the services with their node information causes issues with
anti-entropy on the clients because the kubernetes services are registered directly with
the servers rather than the clients. So, the clients don't have a record
of the service and deregister them. This causes a register/deregister loop
because the sync process automatically re-registers them.
Given that the sync doesn't register things directly to the clients, it
is more correct to register them to a synthetic node (
k8s-syncin thiscase) to indicate that they didn't come from a client registration.
Fixes #40 and #59.