Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Increase golangci-lint timeout to 10m into release/1.0.x #2628

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2621 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


This is meant to solve for recurrent timeouts in several steps, particularly golangci-lint-control-plane and golang-ci-lint-cli.

An accompanying change in consul-k8s-workflows should disable caching until the (unclear) root of the issue can be resolved, or we can disable or clear cache in a more targeted way that solves for these cases.

Note from @DanStough : we've also done this in consul
#2621
hashicorp/consul#17459

Changes proposed in this PR:

  • Disable golangci-lint caching

How I've tested this PR:

How I expect reviewers to test this PR: 👀

Checklist:


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/golangci-lint-increase-timeout/vigorously-enough-stinkbug branch from dd250f1 to 6043dfb Compare July 21, 2023 17:14
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/golangci-lint-increase-timeout/vigorously-enough-stinkbug branch from 21b87e9 to 818efb0 Compare July 21, 2023 17:14
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) July 21, 2023 17:14
@hc-github-team-consul-core hc-github-team-consul-core merged commit c6b1f57 into release/1.0.x Jul 21, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/zalimeni/golangci-lint-increase-timeout/vigorously-enough-stinkbug branch July 21, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants