Enforce services listing at startup to not remove them from consul if still needed #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still needed At startup the servces map in ConsulSyncer is empty. Due to that the watchReapableServices can remove some services from consul that are still needed but for which the controller had not enough time to add them in the services map. This commit enforce the listing of all services at startup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently , at startup the servces map in ConsulSyncer is empty, due to that the watchReapableServices can remove some services from consul that are still needed
but for which the controller had not enough time to add them in the services map.
This PR enforce the listing of all services at startup so we do not remove from consul still existing ones