agentless: enable admin partitions with agentless #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
commented
Sep 27, 2022
| @@ -1,5 +1,6 @@ | |||
| {{- if .Values.controller.enabled }} | |||
| {{- if and .Values.global.adminPartitions.enabled (not .Values.global.enableConsulNamespaces) }}{{ fail "global.enableConsulNamespaces must be true if global.adminPartitions.enabled=true" }}{{ end }} | |||
| {{- if and .Values.externalServers.enabled (not .Values.externalServers.hosts) }}{{ fail "externalServers.hosts must be set if externalServers.enabled is true" }}{{ end -}} | |||
There was a problem hiding this comment.
I'm not going to update bats for controller in this PR because we'll combine this deployment with connect-inject deployment in a future PR before we go GA (NET-994)
ishustava
commented
Sep 27, 2022
| serverHelmValues := map[string]string{ | ||
| "server.exposeGossipAndRPCPorts": "true", | ||
| } | ||
| defaultPartitionHelmValues := make(map[string]string) |
There was a problem hiding this comment.
We don't need server's gossip and rpc ports because they don't need to gossip with clients anymore 🎉
t-eckert
reviewed
Sep 27, 2022
| local actual=$(echo "$spec" | yq '.initContainers[0].command | any(contains("-use-https"))' | tee /dev/stderr) | ||
| [ "${actual}" = "true" ] | ||
| } | ||
|
|
t-eckert
approved these changes
Sep 27, 2022
thisisnotashwin
approved these changes
Sep 27, 2022
* integrate partition-init job with consul-server-connection-manager * integrate controller with consul-server-connection-manager * modify partition token to be be able read all services so that it works with connection manager
76bce3a to
2f1db05
Compare
ishustava
added a commit
that referenced
this pull request
Sep 28, 2022
* integrate partition-init job with consul-server-connection-manager * integrate controller with consul-server-connection-manager * modify partition token to be be able read all services so that it works with connection manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: