-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNI CRT Builds #1454
Closed
Closed
CNI CRT Builds #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get structure in place and CNI installer & plugin building
Add helm charts for CNI installer
* Add file watcher to CNI installer to watch for config file changes and repair breakages. * Wait for CNI config file to show up on the host file system before attempting to install consul-cni configuration. * Add some code to get ready for the next PR that applying iptables rules * Unit tests for installer and plugin scenarios
* Add redirect traffic config and apply it * Unit tests for redirect traffic and webhook changes
- Added a new make target for installing Calico CNI in Kind. The target installs Calico CNI using config files located under /acceptance tests - Added a helper make target for setting up local Kind with Calico just in case anyone wants to run it. - Added a kind.config for setting up the Kind cluster - Added an -enable-cni flag to the acceptance test config so that it can be passed through from CircleCI - Added a nightly circleci job for running the CNI kind tests - I had missed a bats test for the connect-inject template that I merged in a previous PR
- Added a -use-gke flag to the acceptance test command so that the flag can be passed through to the tests - If both, -enable-cni and -use-gke are passed through then the cniBinDir gets set for helm values. - GKE would not install the CNI plugin unless the use security policy was set. - GKE was throwing an error saying that allowPrivilegeEscalation: true needed to be set if privileged: true. Once set, tests passed.
Add EKS as a nightly acceptance test job
- Add AKS as a nightly acceptance test job - Pulled in an updated version of AKS because Azure deprecated the version we were using - Some policy changes pulled in from the GKE PR
…o that docker can copy it
9359807
to
719b176
Compare
Closed in favour of a cleaner #1458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to get the CNI added to the release process using CRT.
Changes proposed in this PR:
All of the above works, except...
The security scanner is looking at the zip file and expects 1 binary per zip and thus fails the security scan. I have contacted the Release Team about this to see if there is a possible workaround.
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: