rename create-controller-token flag to enable-controller #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
reviewed
Mar 3, 2022
ishustava
approved these changes
Mar 3, 2022
| @@ -147,7 +147,7 @@ func (c *Command) init() { | |||
| c.flags.StringVar(&c.flagBindingRuleSelector, "acl-binding-rule-selector", "", | |||
| "Selector string for connectInject ACL Binding Rule.") | |||
|
|
|||
| c.flags.BoolVar(&c.flagCreateControllerPoliciesAndBindings, "create-controller-token", false, | |||
| c.flags.BoolVar(&c.flagEnableController, "enable-controller", false, | |||
| "Toggle for creating acl policies and rolebindings for the controller.") | |||
There was a problem hiding this comment.
Suggested change
| "Toggle for creating acl policies and rolebindings for the controller.") | |
| "Toggle for configuring ACLs for the controller.") |
| @@ -251,7 +251,7 @@ spec: | |||
| {{- end }} | |||
|
|
|||
| {{- if .Values.controller.enabled }} | |||
| -create-controller-token=true \ | |||
| -enable-controller=true \ | |||
There was a problem hiding this comment.
how about -controller=true? It seems similar to patterns we have for partitions.
| @@ -47,7 +47,7 @@ type Command struct { | |||
| flagInjectAuthMethodHost string | |||
| flagBindingRuleSelector string | |||
|
|
|||
| flagCreateControllerPoliciesAndBindings bool | |||
| flagEnableController bool | |||
There was a problem hiding this comment.
This can still stay the same though. Just the name of the flag can be -controller
There was a problem hiding this comment.
I think we usually try to match the var name with flag name. IMO it's kind of nice to know what the flag name is by looking at the command var as you're reading through the code.
16eaf74 to
5bee0db
Compare
e50a4d2 to
fc88732
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
server-acl-initno longer creates a controller token rename the flag to-enable-controller.Changes proposed in this PR:
-create-controller-tokenflag to-enable-controllerforserver-acl-init.How I've tested this PR:
unit tests still pass
How I expect reviewers to test this PR:
Checklist: