chore: update usage of minio admin library #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
approved these changes
Jan 20, 2025
elimt
reviewed
Jan 20, 2025
Comment on lines
+109
to
+111
| // Get sha256 for request header | ||
| sum := sha256.Sum256(nil) | ||
| req.Header.Set("X-Amz-Content-Sha256", hex.EncodeToString(sum[:])) |
There was a problem hiding this comment.
Do we still need to set the header even though it's nil?
There was a problem hiding this comment.
Yes the minio server still expects the sha to be set correctly even with nil content
elimt
approved these changes
Jan 20, 2025
|
(I wasn't able to try this in actual Boundary -- I got an error when trying to import the plugin: Interesting that go mod didn't seem to follow the I'll test the functionality once this gets merged & tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update's Boundary's usage of the madmin-go library, please note the madmin package created in this PR will be tagged and updated after this is merged, at that point we can update ci to run madmin tests as well.