Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters out CR (\r) characters from log messages #173

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Mar 9, 2022

HTTP request and response messages from the AWS API include the CR from the CRLF line endings for HTTP message headers. This appears to be a recent change. teamcity-go-test does not escape the CR characters, causing TeamCity logging to break.

Reference https://www.jetbrains.com/help/teamcity/service-messages.html#Escaped+Values

@gdavison gdavison requested a review from a team as a code owner March 9, 2022 18:17
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit d9108bc into release/v1.x Mar 9, 2022
gdavison added a commit that referenced this pull request Mar 9, 2022
@ewbankkit ewbankkit deleted the v1/filter-log-CR-characters branch February 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants