Include gas fee in ContractCreate and ContractCall record transactionFee fields
#9774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9774 +/- ##
==========================================
Coverage ? 65.44%
Complexity ? 29987
==========================================
Files ? 3297
Lines ? 125585
Branches ? 13027
==========================================
Hits ? 82186
Misses ? 40266
Partials ? 3133 ☔ View full report in Codecov by Sentry. |
...-node/test-clients/src/main/java/com/hedera/services/bdd/spec/utilops/SnapshotMatchMode.java
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/utilops/SnapshotMode.java
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
david-bakin-sl
approved these changes
Nov 8, 2023
...mpl/src/main/java/com/hedera/node/app/service/contract/impl/records/GasFeeRecordBuilder.java
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractCallHandler.java
Show resolved
Hide resolved
...-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/exec/CallOutcomeTest.java
Show resolved
Hide resolved
...est/java/com/hedera/node/app/service/contract/impl/test/records/GasFeeRecordBuilderTest.java
Show resolved
Hide resolved
Neeharika-Sompalli
approved these changes
Nov 8, 2023
ilko-iliev-lime
pushed a commit
that referenced
this pull request
Nov 10, 2023
…ctionFee` fields (#9774) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
…ctionFee` fields (#9774) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
1️⃣ In
contract-service-impl:GasFeeRecordBuilderfor the contract operations that directly deduct the gas cost from the payer account (0.0.2---leave this for mono-service parity).CallOutcomewith thegasPriceused for the contract operation; and then updates records with total assessed gas fees inContractCallHandlerandContractCreateHandler.2️⃣ In
test-clients:SnapshotMode/SnapshotMatchModefiles in old package (incomplete merge)."alias"inFIELDS_TO_SKIP_IN_FUZZY_MATCH./HAPI Test/path segment from@HapiTestrecord stream loc.SnapshotModeOp.