Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE in FileServiceUtil #9688

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix NPE in FileServiceUtil #9688

merged 3 commits into from
Nov 6, 2023

Conversation

povolev15
Copy link
Contributor

Fix NPE in FileServiceUtil

Related issue(s):

Fixes #9685

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 self-assigned this Nov 6, 2023
@povolev15 povolev15 requested a review from a team November 6, 2023 13:37
@povolev15 povolev15 requested a review from a team as a code owner November 6, 2023 13:37
@povolev15 povolev15 requested a review from netopyr November 6, 2023 13:37
@povolev15 povolev15 requested a review from netopyr November 6, 2023 13:44
Copy link

github-actions bot commented Nov 6, 2023

Node: Unit Test Results

    2 272 files      2 272 suites   1h 23m 4s ⏱️
118 348 tests 118 314 ✔️ 34 💤 0
126 609 runs  126 575 ✔️ 34 💤 0

Results for commit b1a7e65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 6, 2023

Node: E2E Test Results

    1 files      1 suites   20m 56s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit b1a7e65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 6, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 49s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit b1a7e65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 6, 2023

Node: HAPI Test Results

1 242 tests   814 ✔️  1h 21m 41s ⏱️
   165 suites  428 💤
   165 files        0

Results for commit b1a7e65.

♻️ This comment has been updated with latest results.

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@povolev15 povolev15 merged commit 450187e into develop Nov 6, 2023
8 of 9 checks passed
@povolev15 povolev15 deleted the 9685-fix-NPE branch November 6, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible NPE in FileServiceUtils.verifyNotSystemFile()
3 participants