Add support for underscored numerical literals in Configuration Converters #9682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2023 13:50
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
0b9d900 to
623d770
Compare
|
Does this PR resolve #9184? |
tinker-michaelj
approved these changes
Nov 8, 2023
timo0
approved these changes
Nov 8, 2023
Ivo-Yankov
pushed a commit
that referenced
this pull request
Nov 9, 2023
…rters (#9682) Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
…rters (#9682) Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
lukelee-sl
added a commit
that referenced
this pull request
Jan 11, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for numerical literals in the ConfigConvertors for
IntegerConverter&LongConvertors.Checklist