Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to failing record regression tests #9672

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add comments to failing record regression tests #9672

merged 1 commit into from
Nov 3, 2023

Conversation

mhess-swl
Copy link
Member

The three remaining tests in TxnRecordRegression fail in both the modular and the mono code, even with a 3 second TTL. This PR just adds comments to revisit them later.

Closes #9622

@mhess-swl
Add comments to record regression tests
e46ff06 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl added the Modularization Issues or PRs related to modularization label Nov 3, 2023
@mhess-swl mhess-swl self-assigned this Nov 3, 2023
@mhess-swl mhess-swl requested a review from a team November 3, 2023 20:47
@mhess-swl mhess-swl requested a review from a team as a code owner November 3, 2023 20:47
kimbor
kimbor reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to create an issue for the future task and put the issue number in the comment.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Node: Unit Test Results

    2 271 files      2 271 suites   1h 23m 28s ⏱️
118 338 tests 118 304 ✔️ 34 💤 0 ❌
126 599 runs  126 565 ✔️ 34 💤 0 ❌

Results for commit e46ff06.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Node: E2E Test Results

    1 files      1 suites   21m 49s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs  332 ✔️ 0 💤 0 ❌

Results for commit e46ff06.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 49s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit e46ff06.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Node: HAPI Test Results

1 242 tests   802 ✔️  1h 16m 57s ⏱️
   165 suites  440 💤
   165 files        0 ❌

Results for commit e46ff06.

@mhess-swl mhess-swl merged commit 824d007 into develop Nov 3, 2023
8 of 9 checks passed
@mhess-swl mhess-swl deleted the 09622_txn-record-regression-tests branch November 3, 2023 22:12
ilko-iliev-lime pushed a commit that referenced this pull request Nov 6, 2023
@mhess-swl @ilko-iliev-lime
Updated Tests (#9672)
ad5b939 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech> <matt.hess@swirldslabs.com>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Added constants to TestHelpers (#9672)
ea794d1 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Added constants to TestHelpers (#9672)
4285160 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Added unset account check to headLongAddressOf (#9672)
0634cb0 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Updated NftTokenInfoCall (#9672)
44f659c 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Updated TokenTupleUtils (#9672)
32fa075 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime pushed a commit that referenced this pull request Nov 6, 2023
@mhess-swl @ilko-iliev-lime
Updated Tests (#9672)
efbca67 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime pushed a commit that referenced this pull request Nov 6, 2023
@mhess-swl @ilko-iliev-lime
Updated Tests (#9672)
e09e3b1 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Updated TokenTupleUtils (#9672)
7ac8c91 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Updated TokenTupleUtils (#9672)
e116bbe 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 6, 2023
@ilko-iliev-lime
Updated TokenTupleUtils (#9672)
a0f8c40 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 7, 2023
@ilko-iliev-lime
Addressed PR comments (#9672)
79cdc9f 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 7, 2023
@ilko-iliev-lime
Addressed PR comments (#9672)
ac8aa65 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 8, 2023
@ilko-iliev-lime
Addressed PR comments (#9672)
0b1a1a0 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 8, 2023
@ilko-iliev-lime
Addressed PR comments (#9672)
92b8add 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 8, 2023
@ilko-iliev-lime
Fixed and enabled negaive cases test in TokenAndTypeCheckSuit (#9672)
b9f6adb 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 8, 2023
@ilko-iliev-lime
Fixed spotless checks (#9672)
6fde063 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 10, 2023
@ilko-iliev-lime
Fixed and enabled negaive cases test in TokenAndTypeCheckSuit (#9672)
a0db51f 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 10, 2023
@ilko-iliev-lime
Fixed spotless checks (#9672)
ce63db2 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 10, 2023
@ilko-iliev-lime
Addressed PR comments (#9672)
09c4b07 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
jsync-swirlds pushed a commit that referenced this pull request Nov 10, 2023
@ilko-iliev-lime @jsync-swirlds
Fixed and enabled negaive cases test in TokenAndTypeCheckSuit (#9672)
a951703 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
jsync-swirlds pushed a commit that referenced this pull request Nov 10, 2023
@ilko-iliev-lime @jsync-swirlds
Fixed spotless checks (#9672)
2f1ae12 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 13, 2023
@ilko-iliev-lime
Removed static call check (#9672)
f2520c7 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 13, 2023
@ilko-iliev-lime
Fied TokenAndTypeCheckSuite (#9672)
9afa204 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 13, 2023
@ilko-iliev-lime
Applied spotless (#9672)
c2cf0f5 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
imalygin pushed a commit that referenced this pull request Nov 13, 2023
@mhess-swl @imalygin
Add comments to failing record regression tests (#9672)
7f54352 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
tinker-michaelj pushed a commit that referenced this pull request Nov 13, 2023
@ilko-iliev-lime
TokenAndTypeCheckFix (#9672) (#9844)
d7078a7 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 13, 2023
@ilko-iliev-lime
Extracred static logic in OwnerOfCall (#9672)
f927bdc 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 15, 2023
@ilko-iliev-lime
Removed unneccessary case (#9672)
5b42a81 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 15, 2023
@ilko-iliev-lime
Applied spotless (#9672)
bf98806 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime added a commit that referenced this pull request Nov 16, 2023
@ilko-iliev-lime
Applied spotless (#9672)
acbbeb3 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@ilko-iliev-lime @nickpoorman
TokenAndTypeCheckFix (#9672) (#9844)
011f464 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimbor kimbor kimbor left review comments

@jsync-swirlds jsync-swirlds jsync-swirlds approved these changes

@povolev15 povolev15 povolev15 approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23

Assignees

@mhess-swl mhess-swl

Labels
Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TxnRecordRegression
4 participants
@mhess-swl @kimbor @povolev15 @jsync-swirlds