-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added heartbeats to wiring framework. #9664
Conversation
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 37s ⏱️ + 21m 37s Results for commit 3388b73. ± Comparison against base commit 450187e. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving because the code is fairly benign. I'm not clear yet on the over all design that the heartbeat scheduler is working towards. Is there a diagram or plan to show this in context?
I've not got a diagram, but there are intended uses for this feature. Currently there are several components that need to "do something" every so often even if they don't get new input. An example of this is the event creator. If it is unable to create an event due to rate limiting, we want it to try again at a later time. This heartbeat feature will allow us to keep using this same pattern with the new wiring framework. |
Signed-off-by: Cody Littley <cody@swirldslabs.com>
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/TaskScheduler.java
Outdated
Show resolved
Hide resolved
...dk/swirlds-common/src/main/java/com/swirlds/common/wiring/schedulers/HeartbeatScheduler.java
Show resolved
Hide resolved
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Closes #9618