Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize fuzzy matching #9661

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Nov 3, 2023

Description:

  • Closes Stabilize SnapshotModeOp fuzzy-matching for additional non-deterministic fields  #9660
  • Allows transactionFee fields to vary by a tinybar by default.
  • Skips expirationTime and parent_consensus_timestamp by default.
  • Permits skipping contractCallResult and functionParameters when these vary by addresses.
  • Tries to read from all 4 recordStreams/ in a HAPI Test network output, in case at least node successfully flushes its streams.
  • Adds mono-service snapshots for two Create2OperationSuite's; these cannot be matched against @HapiTest streams yet because we are missing transactionFee fields in a ContractCreate records. I.e. the current failure is,
        2023-11-03 12:38:16.560 ERROR  539  HapiSpec - Record snapshot fuzzy-match failed
       ... Mismatched field counts  (expected but not find [transactionFee]) between expected receipt {

To fix this for now, we probably need a HandleContext method a TransactionHandler can call to report a non-standard fee charge. 🤔 See #9663.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested a review from a team November 3, 2023 16:47
@tinker-michaelj tinker-michaelj requested a review from a team as a code owner November 3, 2023 16:47
Copy link

github-actions bot commented Nov 3, 2023

Node: Unit Test Results

    2 271 files      2 271 suites   1h 22m 55s ⏱️
118 338 tests 118 304 ✔️ 34 💤 0
126 599 runs  126 565 ✔️ 34 💤 0

Results for commit 824277d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: E2E Test Results

    1 files      1 suites   20m 31s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 824277d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 47s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 824277d.

♻️ This comment has been updated with latest results.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

github-actions bot commented Nov 3, 2023

Node: HAPI Test Results

1 242 tests   802 ✔️  1h 15m 38s ⏱️
   165 suites  440 💤
   165 files        0

Results for commit 824277d.

♻️ This comment has been updated with latest results.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from Neeharika-Sompalli and a team November 6, 2023 16:17
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tinker-michaelj tinker-michaelj merged commit 8815e27 into develop Nov 6, 2023
8 of 9 checks passed
@tinker-michaelj tinker-michaelj deleted the 09660-stabilize-fuzzy-matching branch November 6, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize SnapshotModeOp fuzzy-matching for additional non-deterministic fields
4 participants