Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiring Framework #9482

Merged
merged 23 commits into from
Nov 3, 2023
Merged

Wiring Framework #9482

merged 23 commits into from
Nov 3, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #9005

Created new wiring framework.
1ed4636 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.44 milestone Oct 25, 2023
@cody-littley cody-littley self-assigned this Oct 25, 2023
@cody-littley cody-littley requested review from a team as code owners October 25, 2023 19:22
@cody-littley cody-littley mentioned this pull request Oct 25, 2023
Closed
@cody-littley cody-littley changed the title Created new wiring framework. Wiring Framework Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Node: HAPI Test Results

1 242 tests   783 ✔️  1h 26m 22s ⏱️
   165 suites  459 💤
   165 files        0 ❌

Results for commit 30943f3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   22m 17s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs  332 ✔️ 0 💤 0 ❌

Results for commit 30943f3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Node: Unit Test Results

    2 272 files      2 272 suites   1h 26m 22s ⏱️
118 345 tests 118 311 ✔️ 34 💤 0 ❌
126 606 runs  126 572 ✔️ 34 💤 0 ❌

Results for commit 30943f3.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@f58572e). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #9482   +/-   ##
==========================================
  Coverage           ?   65.40%           
  Complexity         ?    29945           
==========================================
  Files              ?     3293           
  Lines              ?   125284           
  Branches           ?    12980           
==========================================
  Hits               ?    81943           
  Misses             ?    40229           
  Partials           ?     3112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Node: Integration Test Results

280 tests   280 ✔️  32m 51s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 30943f3.

♻️ This comment has been updated with latest results.

litt3
litt3 reviewed Oct 26, 2023
View reviewed changes
...sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/counters/BackpressureBlocker.java Show resolved Hide resolved
...irlds-common/src/main/java/com/swirlds/common/wiring/counters/BackpressureObjectCounter.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/counters/EmptyBlocker.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/counters/EmptyBlocker.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/counters/ObjectCounter.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/WiringModel.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/WiringModel.java Outdated Show resolved Hide resolved
...rm-sdk/swirlds-common/src/test/java/com/swirlds/common/wiring/benchmark/WiringBenchmark.java Outdated Show resolved Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/wiring/EventSignatureValidationWire.java Outdated Show resolved Hide resolved
...rm-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/wiring/OrphanBufferWire.java Outdated Show resolved Hide resolved
Cody Littley added 4 commits October 27, 2023 08:36
Merge branch 'develop' into 09005-wiring-framework
f7fb137 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Made suggested changes.
6914bb6 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Removed unused class.
4d4ff34 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Fix build problem.
c54e6e4 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Scheduler no longer implements output wire.
ff62894 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Cody Littley added 4 commits November 1, 2023 14:54
Make suggested changes.
c34f156 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Made suggested changes.
5bf298d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Simplify transformer implementations.
6e0fdeb 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Merge branch 'develop' into 09005-wiring-framework
432d4fc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Cody Littley added 2 commits November 2, 2023 09:26
Merge branch 'develop' into 09005-wiring-framework
0ca759b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Change backpressure implementation.
1516672 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
litt3
litt3 previously approved these changes Nov 2, 2023
View reviewed changes
Move complexity into backpressure blocker object.
41302db 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@poulok poulok modified the milestones: v0.44, v0.45 Nov 2, 2023
litt3
litt3 previously approved these changes Nov 2, 2023
View reviewed changes
Made suggested change.
683bc0a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit 972cdff into develop Nov 3, 2023
10 of 11 checks passed
@cody-littley cody-littley deleted the 09005-wiring-framework branch November 3, 2023 13:18
imalygin pushed a commit that referenced this pull request Nov 13, 2023
@cody-littley @imalygin
Wiring Framework (#9482)
6913b72 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegMazurov OlegMazurov OlegMazurov left review comments

@litt3 litt3 litt3 approved these changes

@poulok poulok poulok approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs left review comments

@jasperpotts jasperpotts Awaiting requested review from jasperpotts

@tomzhenghedera tomzhenghedera Awaiting requested review from tomzhenghedera tomzhenghedera was automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

@hendrikebbers hendrikebbers Awaiting requested review from hendrikebbers hendrikebbers was automatically assigned from hashgraph/platform-base

@imalygin imalygin Awaiting requested review from imalygin imalygin was automatically assigned from hashgraph/platform-data

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

Prototype wiring framework
6 participants
@cody-littley @lpetrovic05 @OlegMazurov @poulok @litt3 @edward-swirldslabs