Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TransactionRateMultiplierSource #9305

Merged

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Oct 17, 2023

Description:

Implement modularized version of TxnRateFeeMultiplierSource i.e. EntityUtilizationMultiplier.

Additionally ported ThrottleMultiplierSource implementation to modularized i.e. ThrottleMultiplier, because in order to implement EntityUtilizationMultiplier.currentMultiplier() we need to pass an additional HederaState state parameter and conforming to interface defined in mono became kind of a struggle.

Related issue(s):

Fixes #9223

Notes for reviewer:

Currently the CongestionMultipliers.maxCurrentMultiplier() method is not called anywhere, that will be done as part of #9178.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: HAPI Test Results

1 227 tests   751 ✔️  1h 7m 55s ⏱️
   165 suites  476 💤
   165 files        0

Results for commit c9f83e7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: Unit Test Results

    2 262 files      2 262 suites   1h 38m 7s ⏱️
118 254 tests 118 220 ✔️ 34 💤 0
126 513 runs  126 479 ✔️ 34 💤 0

Results for commit c9f83e7.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (c85c433) 0.00% compared to head (c9f83e7) 65.27%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #9305       +/-   ##
==============================================
+ Coverage           0   65.27%   +65.27%     
- Complexity         0    29653    +29653     
==============================================
  Files              0     3260     +3260     
  Lines              0   124379   +124379     
  Branches           0    12895    +12895     
==============================================
+ Hits               0    81188    +81188     
- Misses             0    40119    +40119     
- Partials           0     3072     +3072     
Files Coverage Δ
...ode/app/fees/congestion/CongestionMultipliers.java 100.00% <100.00%> (ø)
...app/workflows/dispatcher/WritableStoreFactory.java 90.62% <100.00%> (ø)
...app/workflows/handle/SystemFileUpdateFacility.java 66.66% <100.00%> (ø)
...n/java/com/hedera/node/config/data/FeesConfig.java 100.00% <ø> (ø)
...p/throttle/impl/NetworkUtilizationManagerImpl.java 6.49% <28.57%> (ø)
...-app/src/main/java/com/hedera/node/app/Hedera.java 0.00% <0.00%> (ø)
...p/fees/congestion/EntityUtilizationMultiplier.java 92.39% <92.39%> (ø)
...a/node/app/fees/congestion/ThrottleMultiplier.java 70.64% <70.64%> (ø)

... and 3252 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: E2E Test Results

    1 files      1 suites   21m 43s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit c9f83e7.

♻️ This comment has been updated with latest results.

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 40s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit c9f83e7.

♻️ This comment has been updated with latest results.

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
actual entity count

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga marked this pull request as ready for review October 17, 2023 14:01
@MiroslavGatsanoga MiroslavGatsanoga requested a review from a team October 17, 2023 14:01
@MiroslavGatsanoga MiroslavGatsanoga requested a review from a team as a code owner October 17, 2023 14:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MiroslavGatsanoga and others added 8 commits October 23, 2023 17:52
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
…-source

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @MiroslavGatsanoga !

@MiroslavGatsanoga MiroslavGatsanoga merged commit 6f96c20 into develop Oct 31, 2023
10 of 11 checks passed
@MiroslavGatsanoga MiroslavGatsanoga deleted the 09223-modularized-txn-rate-fee-multiplier-source branch October 31, 2023 15:13
imalygin pushed a commit that referenced this pull request Nov 13, 2023
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Co-authored-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement modularized version of TxnRateFeeMultiplierSource
3 participants