-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TransactionRateMultiplierSource #9305
Implement TransactionRateMultiplierSource #9305
Conversation
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9305 +/- ##
==============================================
+ Coverage 0 65.27% +65.27%
- Complexity 0 29653 +29653
==============================================
Files 0 3260 +3260
Lines 0 124379 +124379
Branches 0 12895 +12895
==============================================
+ Hits 0 81188 +81188
- Misses 0 40119 +40119
- Partials 0 3072 +3072
☔ View full report in Codecov by Sentry. |
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
actual entity count Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
…-source Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @MiroslavGatsanoga !
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> Co-authored-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Description:
Implement modularized version of
TxnRateFeeMultiplierSource
i.e.EntityUtilizationMultiplier
.Additionally ported
ThrottleMultiplierSource
implementation to modularized i.e.ThrottleMultiplier
, because in order to implementEntityUtilizationMultiplier.currentMultiplier()
we need to pass an additionalHederaState state
parameter and conforming to interface defined in mono became kind of a struggle.Related issue(s):
Fixes #9223
Notes for reviewer:
Currently the
CongestionMultipliers.maxCurrentMultiplier()
method is not called anywhere, that will be done as part of #9178.Checklist