Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unneeded calls to swirlds-common removed #9003

Merged
merged 4 commits into from
Oct 31, 2023
Merged

unneeded calls to swirlds-common removed #9003

merged 4 commits into from
Oct 31, 2023

Conversation

hendrikebbers
Copy link
Member

first part of #9002

@hendrikebbers
unneeded calls to swirlds-common removed
e52493a 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers hendrikebbers self-assigned this Oct 3, 2023
@hendrikebbers hendrikebbers marked this pull request as ready for review October 3, 2023 13:41
@hendrikebbers hendrikebbers requested review from a team as code owners October 3, 2023 13:41
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Node: Unit Test Results

    2 259 files      2 259 suites   1h 23m 33s ⏱️
118 232 tests 118 198 ✔️ 34 💤 0 ❌
126 491 runs  126 457 ✔️ 34 💤 0 ❌

Results for commit dfeb0d4.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (debf8c1) 0.00% compared to head (75fa726) 41.32%.
Report is 181 commits behind head on develop.

❗ Current head 75fa726 differs from pull request most recent head dfeb0d4. Consider uploading reports for the commit dfeb0d4 to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #9003       +/-   ##
==============================================
+ Coverage           0   41.32%   +41.32%     
- Complexity         0     7908     +7908     
==============================================
  Files              0     1457     +1457     
  Lines              0    54200    +54200     
  Branches           0     5182     +5182     
==============================================
+ Hits               0    22400    +22400     
- Misses             0    30432    +30432     
- Partials           0     1368     +1368
Files Coverage Δ
.../config/impl/internal/ConfigPropertiesService.java 89.28% <100.00%> (ø)
...wirlds/config/impl/internal/ConfigurationImpl.java 82.05% <100.00%> (ø)
...config/impl/validators/DefaultConfigViolation.java 100.00% <100.00%> (ø)
.../swirlds/config/impl/validators/MinConstraint.java 100.00% <100.00%> (ø)
...ds/config/impl/validators/MinLengthConstraint.java 100.00% <100.00%> (ø)
...nfig/impl/validators/PropertyExistsConstraint.java 100.00% <100.00%> (ø)
...validators/PropertyValueConvertableConstraint.java 76.47% <100.00%> (ø)

... and 1450 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Node: Integration Test Results

280 tests   280 ✔️  33m 0s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit dfeb0d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Node: HAPI Test Results

1 227 tests   751 ✔️  1h 8m 9s ⏱️
   165 suites  476 💤
   165 files        0 ❌

Results for commit dfeb0d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   21m 23s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs  332 ✔️ 0 💤 0 ❌

Results for commit dfeb0d4.

♻️ This comment has been updated with latest results.

timo0
timo0 previously approved these changes Oct 6, 2023
View reviewed changes
JeffreyDallas
JeffreyDallas previously approved these changes Oct 6, 2023
View reviewed changes
@timo0 timo0 self-assigned this Oct 26, 2023
@timo0 timo0 added this to the v0.44 milestone Oct 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timo0
Fix tests
dfeb0d4 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 dismissed stale reviews from JeffreyDallas, edward-swirldslabs, and themself via dfeb0d4 October 30, 2023 09:12
@timo0 timo0 requested review from timo0 and JeffreyDallas October 30, 2023 09:13
@timo0 timo0 merged commit f1833d5 into develop Oct 31, 2023
8 of 9 checks passed
@timo0 timo0 deleted the #9002-remove-dependencies branch October 31, 2023 14:29
imalygin pushed a commit that referenced this pull request Nov 13, 2023
@hendrikebbers @timo0 @imalygin
unneeded calls to swirlds-common removed (#9003)
57836e6 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Co-authored-by: Timo Brandstätter <timo@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@JeffreyDallas JeffreyDallas JeffreyDallas approved these changes

@timo0 timo0 timo0 approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

Assignees

@timo0 timo0

@hendrikebbers hendrikebbers

Labels
None yet
Projects
None yet
Milestone
v0.44
Development

Successfully merging this pull request may close these issues.
4 participants
@hendrikebbers @timo0 @JeffreyDallas @edward-swirldslabs