Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00208 Postgres setup guide in markdown format #212

Merged
merged 14 commits into from
May 14, 2020
Merged

00208 Postgres setup guide in markdown format #212

merged 14 commits into from
May 14, 2020

Conversation

qnswirlds
Copy link
Contributor

Related issue(s):
Closes #208

Summary of the change:

  • Provide a Postgres setup guide in markdown format
  • Update top-level README.md

tinker-michaelj
tinker-michaelj approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ljianghedera
ljianghedera approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@ljianghedera ljianghedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@steven-sheehy
Copy link
Member

Should be named lowercase and kebab case

@qnswirlds
Copy link
Contributor Author

Do you mean POSTGRESQL_SETUP_GUIDE.md --> postgresql-setup-guide.md, @steven-sheehy?

@steven-sheehy
Copy link
Member

@qnswirlds Yes, sorry should've clarified.

@qnswirlds
Copy link
Contributor Author

Done. Please help review again @steven-sheehy. Thank you!

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #212   +/-   ##
=========================================
  Coverage     71.16%   71.16%           
  Complexity     3216     3216           
=========================================
  Files           292      292           
  Lines         12289    12289           
  Branches       1353     1353           
=========================================
  Hits           8745     8745           
  Misses         3076     3076           
  Partials        468      468

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8143b77...64bcc56. Read the comment docs.

steven-sheehy
steven-sheehy approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@qnswirlds qnswirlds merged commit 856a700 into master May 14, 2020
@qnswirlds qnswirlds deleted the 00208-D-postgres-setup-guide-md branch May 14, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljianghedera ljianghedera ljianghedera approved these changes

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@noshmody noshmody Awaiting requested review from noshmody

@anighanta anighanta Awaiting requested review from anighanta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert PostgreSQL setup guide into markdown format
4 participants
@qnswirlds @steven-sheehy @tinker-michaelj @ljianghedera