01715: Fail CI step/workflow on javadoc warnings #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quan Nguyen <quan.nguyen@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #1719 +/- ##
=========================================
Coverage 92.17% 92.17%
Complexity 6426 6426
=========================================
Files 490 490
Lines 18408 18408
Branches 1904 1904
=========================================
Hits 16967 16967
Misses 974 974
Partials 467 467 Continue to review full report at Codecov.
|
Neeharika-Sompalli
approved these changes
Jun 30, 2021
qnswirlds
commented
Jun 30, 2021
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <phase>install</phase> |
There was a problem hiding this comment.
Note that this phase setting allows mvn clean install to pass on javadoc warnings, which allows developers to take care of those warnings at a later time (when they run mvn javadoc:javadoc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s):
Closes #1715