-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace AddressBook with Roster in SignedState #17076
chore: replace AddressBook with Roster in SignedState #17076
Conversation
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17076 +/- ##
=============================================
- Coverage 64.25% 64.24% -0.02%
+ Complexity 20827 20817 -10
=============================================
Files 2547 2547
Lines 95721 95707 -14
Branches 10018 10014 -4
=============================================
- Hits 61510 61485 -25
- Misses 30599 30610 +11
Partials 3612 3612
|
...orm-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/roster/RosterRetriever.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedState.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedState.java
Show resolved
Hide resolved
...s-platform-core/src/main/java/com/swirlds/platform/state/snapshot/SignedStateFileWriter.java
Show resolved
Hide resolved
...rm-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/StateSigningTests.java
Show resolved
Hide resolved
...rm-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/StateSigningTests.java
Outdated
Show resolved
Hide resolved
...rm-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/StateSigningTests.java
Outdated
Show resolved
Hide resolved
...rc/testFixtures/java/com/swirlds/platform/test/fixtures/addressbook/RandomRosterBuilder.java
Outdated
Show resolved
Hide resolved
...re/src/testFixtures/java/com/swirlds/platform/test/fixtures/addressbook/RosterTestUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedState.java
Show resolved
Hide resolved
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
@anthony-swirldslabs : Can you please review one last time (hopefully). I had some merge conflicts after you merged your last set of changes and I want to make sure I didn't miss anything when I resolved the conflicts. |
Description:
Removes the usage of address books in SignedState and replaces it with the new roster.
Related issue(s):
Fixes #16906
Notes for reviewer:
Checklist