Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace AddressBook with Roster in SignedState #17076

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

timfn-hg
Copy link
Contributor

Description:
Removes the usage of address books in SignedState and replaces it with the new roster.

Related issue(s):

Fixes #16906

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
@timfn-hg timfn-hg added this to the v0.58 milestone Dec 16, 2024
@timfn-hg timfn-hg self-assigned this Dec 16, 2024
@timfn-hg timfn-hg requested a review from a team as a code owner December 16, 2024 19:53
Copy link

codacy-production bot commented Dec 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 73.91%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (13bd3a9) 98486 64931 65.93%
Head commit (aaec936) 98472 (-14) 64906 (-25) 65.91% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17076) 46 34 73.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.

Project coverage is 64.24%. Comparing base (13bd3a9) to head (aaec936).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../java/com/swirlds/platform/roster/RosterUtils.java 16.66% 5 Missing ⚠️
...com/swirlds/platform/state/signed/SignedState.java 90.32% 2 Missing and 1 partial ⚠️
...s/platform/recovery/internal/RecoveryPlatform.java 0.00% 2 Missing ⚠️
...rm/state/snapshot/DefaultStateSnapshotManager.java 50.00% 2 Missing ⚠️
...irlds/platform/recovery/EventRecoveryWorkflow.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #17076      +/-   ##
=============================================
- Coverage      64.25%   64.24%   -0.02%     
+ Complexity     20827    20817      -10     
=============================================
  Files           2547     2547              
  Lines          95721    95707      -14     
  Branches       10018    10014       -4     
=============================================
- Hits           61510    61485      -25     
- Misses         30599    30610      +11     
  Partials        3612     3612              
Files with missing lines Coverage Δ
...m/swirlds/platform/reconnect/ReconnectTeacher.java 77.65% <100.00%> (ø)
...a/com/swirlds/platform/roster/RosterRetriever.java 79.26% <ø> (ø)
...platform/state/snapshot/SignedStateFileWriter.java 88.88% <100.00%> (ø)
...irlds/platform/recovery/EventRecoveryWorkflow.java 18.27% <0.00%> (ø)
...s/platform/recovery/internal/RecoveryPlatform.java 0.00% <0.00%> (ø)
...rm/state/snapshot/DefaultStateSnapshotManager.java 77.65% <50.00%> (ø)
...com/swirlds/platform/state/signed/SignedState.java 80.76% <90.32%> (-3.81%) ⬇️
.../java/com/swirlds/platform/roster/RosterUtils.java 67.67% <16.66%> (+0.65%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
@timfn-hg
Copy link
Contributor Author

@anthony-swirldslabs : Can you please review one last time (hopefully). I had some merge conflicts after you merged your last set of changes and I want to make sure I didn't miss anything when I resolved the conflicts.

@timfn-hg timfn-hg merged commit 7ffc174 into develop Dec 17, 2024
45 checks passed
@timfn-hg timfn-hg deleted the timfn/16906-refactor-signedstate-addressbook branch December 17, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace AddressBook with Roster in SignedState
3 participants