Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mirror node team to a dir in codeowners #17053

Merged

Conversation

PavelSBorisov
Copy link
Member

Description:
Add the @hashgraph/mirror-node team to the CODEOWNERS file, line below:
/hapi/hedera-protobufs/services

Related issue(s):

Fixes #17025

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
@PavelSBorisov PavelSBorisov added the Audit Issues resulting from a code or process audit label Dec 13, 2024
@PavelSBorisov PavelSBorisov self-assigned this Dec 13, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners December 13, 2024 12:27
@PavelSBorisov PavelSBorisov linked an issue Dec 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (e20b66a) to head (8f35177).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #17053   +/-   ##
==========================================
  Coverage      64.09%   64.09%           
  Complexity     20729    20729           
==========================================
  Files           2543     2543           
  Lines          95458    95458           
  Branches        9993     9993           
==========================================
  Hits           61187    61187           
  Misses         30664    30664           
  Partials        3607     3607           

Impacted file tree graph

Copy link

codacy-production bot commented Dec 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e20b66a) 98223 64603 65.77%
Head commit (8f35177) 98223 (+0) 64603 (+0) 65.77% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17053) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rbarkerSL rbarkerSL added this to the v0.58 milestone Dec 13, 2024
@rbarkerSL rbarkerSL assigned rbarkerSL and unassigned rbarkerSL Dec 13, 2024
@PavelSBorisov PavelSBorisov merged commit d0ac51b into develop Dec 16, 2024
46 checks passed
@PavelSBorisov PavelSBorisov deleted the 17025-add-mirror-node-team-to-codeowners-protobuf branch December 16, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audit Issues resulting from a code or process audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add mirror-node team to CODEOWNERS protobuf
3 participants