chore: use RosterRetriever in RosterUtils.buildRosterHistory #16923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fix removes the last meaningful use of the
PlatformStateAccessor.getPreviousAddressBook()
by making theRosterUtils.buildRosterHistory
use the RosterRetriever calls instead of fetching the current/previous AddressBooks directly from the PlatformState.The RosterRetriever would automatically fetch the data from the RosterState/RosterMap once we start populating these states. Until then, the code will automatically fall back to reading the current/previous ABs from the PlatformState and converting them to rosters.
A few remaining usages of the
PlatformStateAccessor.getPreviousAddressBook()
are listed in the #16922 and cannot be removed immediately.Related issue(s):
Fixes #16922
Notes for reviewer:
Tests should pass.
Checklist