-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: log4j overhead for inactive markers is too high #16921
Conversation
Signed-off-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16921 +/- ##
=============================================
- Coverage 63.89% 63.87% -0.03%
Complexity 20603 20603
=============================================
Files 2541 2541
Lines 95300 95314 +14
Branches 9957 9967 +10
=============================================
- Hits 60894 60882 -12
- Misses 30803 30827 +24
- Partials 3603 3605 +2
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - looks good
Description:
Downgrade some logs to
DEBUG
to reduce overhead.Related issue(s):
Fixes #16914
Notes for reviewer:
Checklist