-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enhance SwirldState preHandle and handleConsensusRound methods with consumer for system transactions #16897
refactor: enhance SwirldState preHandle and handleConsensusRound methods with consumer for system transactions #16897
Conversation
…ods with consumer for system transactions Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16897 +/- ##
=============================================
- Coverage 63.89% 63.89% -0.01%
- Complexity 20599 20600 +1
=============================================
Files 2541 2541
Lines 95241 95243 +2
Branches 9952 9952
=============================================
+ Hits 60852 60853 +1
- Misses 30792 30793 +1
Partials 3597 3597
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldState.java
Outdated
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/eventhandling/DefaultTransactionPrehandler.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/TransactionHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Description:
To accommodate the serializing of transaction bytes inside hedera.app and get system transactions back to the platform we should make a change in the core hedera.app entry point which is SwirldState API.
We should enhance
preHandle
andhandleConsensusRound
methods with an additional argument, which is a callback in the form ofConsumer<List<ScopedSystemTransaction<StateSignatureTransaction>>> stateSignatureTransactions
It will be later used to populate SystemTransactions in it.
Related issue(s):
Fixes #16703
Notes for reviewer:
Checklist