Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 16863 Fixed MapValueFCQTests failures #16864

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

imalygin
Copy link
Member

@imalygin imalygin commented Dec 2, 2024

Description:

This PR fixes MapValueFCQTests. There were two reasons for it to fail:

  • certificate files were missing in the classpath
  • state.init method was invoked twice and that caused failures

Related issue(s):

Fixes #16863

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@imalygin imalygin requested a review from a team as a code owner December 2, 2024 22:21
@imalygin imalygin requested a review from timo0 December 2, 2024 22:21
@imalygin imalygin self-assigned this Dec 2, 2024
@imalygin imalygin added this to the v0.57 milestone Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Node: Timing Sensitive Unit Test Results

   91 files  ±0      1 errors  90 suites  ±0   29m 20s ⏱️ +10s
8 222 tests +3  8 197 ✅ +4  25 💤 ±0  0 ❌  - 1 
8 912 runs  +3  8 887 ✅ +4  25 💤 ±0  0 ❌  - 1 

For more details on these parsing errors, see this check.

Results for commit 37ff07c. ± Comparison against base commit f881978.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
com.swirlds.demo.merkle.map.MapValueFCQTests ‑ initializationError
com.swirlds.demo.merkle.map.MapValueFCQTests ‑ 1 => addRecords=10, deleteTransactions=10, transferTransactions=10
com.swirlds.demo.merkle.map.MapValueFCQTests ‑ addAndDeleteRecordsTest()
com.swirlds.demo.merkle.map.MapValueFCQTests ‑ purgeExpirationTest()
com.swirlds.demo.merkle.map.MapValueFCQTests ‑ serializeDeserializeTest()

@imalygin imalygin changed the title fix: 16863 Fixed MapValueFCQTests failures fix: 16863 Fixed MapValueFCQTests failures Dec 2, 2024
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (029a73f) to head (af25681).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16864   +/-   ##
==========================================
  Coverage      63.65%   63.65%           
- Complexity     20447    20448    +1     
==========================================
  Files           2538     2538           
  Lines          94927    94927           
  Branches        9919     9919           
==========================================
+ Hits           60424    60425    +1     
+ Misses         30891    30889    -2     
- Partials        3612     3613    +1     

see 4 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Dec 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (029a73f) 97692 63846 65.35%
Head commit (af25681) 97692 (+0) 63848 (+2) 65.36% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16864) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: it's not exactly clear where the first call to state.init actually occurs.

Also, it's unclear if the certs data files are used by this test exclusively. And if not, then it's unclear why other tests using these files didn't fail, or whether those other tests will continue to pass after the files are moved.

But if all PR checks pass, I suppose the fix is good.

@rbarkerSL rbarkerSL added the P0 An issue impacting production environments or impacting multiple releases or multiple individuals. label Dec 3, 2024
@rbarkerSL rbarkerSL merged commit 409de85 into develop Dec 3, 2024
46 checks passed
@rbarkerSL rbarkerSL deleted the 16863-MapValueFCQTests-fix branch December 3, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapValueFCQTests is failing
3 participants