-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 16863 Fixed MapValueFCQTests failures #16864
Conversation
Node: Timing Sensitive Unit Test Results 91 files ±0 1 errors 90 suites ±0 29m 20s ⏱️ +10s For more details on these parsing errors, see this check. Results for commit 37ff07c. ± Comparison against base commit f881978. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
|
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
37ff07c
to
9e2cd17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16864 +/- ##
==========================================
Coverage 63.65% 63.65%
- Complexity 20447 20448 +1
==========================================
Files 2538 2538
Lines 94927 94927
Branches 9919 9919
==========================================
+ Hits 60424 60425 +1
+ Misses 30891 30889 -2
- Partials 3612 3613 +1 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: it's not exactly clear where the first call to state.init
actually occurs.
Also, it's unclear if the certs data files are used by this test exclusively. And if not, then it's unclear why other tests using these files didn't fail, or whether those other tests will continue to pass after the files are moved.
But if all PR checks pass, I suppose the fix is good.
Description:
This PR fixes
MapValueFCQTests
. There were two reasons for it to fail:state.init
method was invoked twice and that caused failuresRelated issue(s):
Fixes #16863
Notes for reviewer:
Checklist