Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase CryptoGetAccountBalance throttle #16857

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Dec 2, 2024

Description:
Update CryptoGetAccountBalance throttle in previewnet, testnet, mainnet to the number of network nodes times 1,000,000 plus a buffer

Related issue(s):
Fixes #16850

…et to the number of network nodes times 1,000,000 plus a buffer

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor added this to the v0.58 milestone Dec 2, 2024
@kimbor kimbor self-assigned this Dec 2, 2024
@kimbor kimbor changed the title chore: Update CryptoGetAccountBalance throttle chore: Increase CryptoGetAccountBalance throttle Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (f881978) to head (6aeccdd).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16857   +/-   ##
==========================================
  Coverage      63.64%   63.64%           
  Complexity     20430    20430           
==========================================
  Files           2538     2538           
  Lines          94843    94843           
  Branches        9908     9908           
==========================================
  Hits           60362    60362           
  Misses         30877    30877           
  Partials        3604     3604           

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f881978) 97608 63776 65.34%
Head commit (6aeccdd) 97608 (+0) 63776 (+0) 65.34% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16857) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @kimbor

@kimbor kimbor merged commit 2889851 into develop Dec 3, 2024
82 checks passed
@kimbor kimbor deleted the 16850-update-getbalance-throttle branch December 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GetBalance throttle
2 participants