Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick #16789 - Implement hss functions #16803

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

lukelee-sl
Copy link
Member

@lukelee-sl lukelee-sl commented Nov 26, 2024

Description:
Cherry pick of #16789 which implements the signSchedule and authorizeSchedule functions for HSS.

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
@lukelee-sl lukelee-sl added this to the v0.57 milestone Nov 26, 2024
@lukelee-sl lukelee-sl self-assigned this Nov 26, 2024
@lukelee-sl lukelee-sl requested review from a team and tinker-michaelj as code owners November 26, 2024 22:34
Copy link

codacy-production bot commented Nov 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 79.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cd75b68) 97698 63852 65.36%
Head commit (65a4486) 97782 (+84) 63922 (+70) 65.37% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16803) 93 74 79.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 72.04301% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (cd75b68) to head (65a4486).
Report is 3 commits behind head on release/0.57.

Files with missing lines Patch % Lines
...racts/hss/signschedule/SignScheduleTranslator.java 66.07% 14 Missing and 5 partials ⚠️
...mcontracts/hss/DispatchForResponseCodeHssCall.java 92.00% 1 Missing and 1 partial ⚠️
...rvice/contract/impl/exec/TransactionProcessor.java 66.66% 0 Missing and 1 partial ⚠️
.../impl/exec/scope/HandleHederaNativeOperations.java 0.00% 1 Missing ⚠️
...mpl/exec/scope/HandleSystemContractOperations.java 0.00% 1 Missing ⚠️
...ntract/impl/exec/scope/HederaNativeOperations.java 0.00% 1 Missing ⚠️
...ec/systemcontracts/common/AbstractCallAttempt.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.57   #16803   +/-   ##
===============================================
  Coverage           63.65%   63.66%           
- Complexity          20427    20444   +17     
===============================================
  Files                2547     2547           
  Lines               94933    95017   +84     
  Branches             9917     9928   +11     
===============================================
+ Hits                60426    60488   +62     
- Misses              30892    30906   +14     
- Partials             3615     3623    +8     
Files with missing lines Coverage Δ
...orkflows/handle/dispatch/ChildDispatchFactory.java 91.30% <100.00%> (+0.86%) ⬆️
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...p/service/contract/impl/exec/gas/DispatchType.java 100.00% <100.00%> (ø)
...impl/exec/scope/QuerySystemContractOperations.java 100.00% <100.00%> (ø)
...ract/impl/exec/scope/SystemContractOperations.java 100.00% <ø> (ø)
...t/impl/exec/systemcontracts/HssSystemContract.java 66.66% <ø> (ø)
.../contract/impl/state/DispatchingEvmFrameState.java 89.47% <ø> (ø)
...rvice/contract/impl/exec/TransactionProcessor.java 94.38% <66.66%> (+0.12%) ⬆️
.../impl/exec/scope/HandleHederaNativeOperations.java 92.30% <0.00%> (-2.43%) ⬇️
...mpl/exec/scope/HandleSystemContractOperations.java 95.12% <0.00%> (-2.38%) ⬇️
... and 4 more

... and 2 files with indirect coverage changes

Impacted file tree graph

stoyanov-st
stoyanov-st previously approved these changes Nov 27, 2024
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming cherry-pick

@david-bakin-sl
Copy link
Member

This is in fact a cherry pick of 2 commits. (Diffs are exact.). But the base PR doesn't have 2 checkmarks yet and isn't merged yet. (I'll come back and LGTM when that happens.)

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
…atch

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @lukelee-sl !

@iwsimon iwsimon merged commit 6529fd3 into release/0.57 Dec 2, 2024
45 checks passed
@iwsimon iwsimon deleted the 16789-cherry-pick branch December 2, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants