Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update panel-config for node-jrs-panel in XTS suite #16802

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

rbarkerSL
Copy link
Contributor

@rbarkerSL rbarkerSL commented Nov 26, 2024

Description:

Updates the panel-config for zxf-dry-run-extended-test-suite.yaml and zxcron-extended-test-suite.yaml

Related issue(s):

Fixes #16800

Checklist

  • Tested (unit, integration, etc.)

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 26, 2024

Node: Timing Sensitive Unit Test Results

   91 files  ±0      1 errors  90 suites  ±0   28m 40s ⏱️ ±0s
8 219 tests ±0  8 193 ✅ ±0  25 💤 ±0  1 ❌ ±0 
8 909 runs  ±0  8 883 ✅ ±0  25 💤 ±0  1 ❌ ±0 

For more details on these parsing errors and failures, see this check.

Results for commit 2cd214a. ± Comparison against base commit f8ea1cd.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Nov 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f8ea1cd) 97522 63622 65.24%
Head commit (2cd214a) 97522 (+0) 63622 (+0) 65.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16802) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rbarkerSL rbarkerSL self-assigned this Nov 26, 2024
@rbarkerSL rbarkerSL added this to the v0.57 milestone Nov 26, 2024
@rbarkerSL rbarkerSL added the github_actions Pull requests that update GitHub Actions code label Nov 26, 2024
@rbarkerSL
Copy link
Contributor Author

Testing is on this xts-dry-run workflow

@rbarkerSL rbarkerSL marked this pull request as ready for review November 26, 2024 20:34
@rbarkerSL rbarkerSL requested review from a team as code owners November 26, 2024 20:34
poulok
poulok previously approved these changes Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.53%. Comparing base (f8ea1cd) to head (2cd214a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16802   +/-   ##
==========================================
  Coverage      63.53%   63.53%           
  Complexity     20372    20372           
==========================================
  Files           2537     2537           
  Lines          94757    94757           
  Branches        9904     9904           
==========================================
  Hits           60206    60206           
  Misses         30946    30946           
  Partials        3605     3605           

Impacted file tree graph

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL requested a review from a team as a code owner November 27, 2024 00:07
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tyvm @rbarkerSL

@rbarkerSL rbarkerSL merged commit 5ec10f1 into develop Nov 27, 2024
62 of 64 checks passed
@rbarkerSL rbarkerSL deleted the 16800-update-the-hedera-jrs-test-in-xts branch November 27, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Hedera JRS Test in XTS
4 participants