Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump slackapi/slack-github-action from 1.25.0 to 2.0.0 #16773

Conversation

PavelSBorisov
Copy link
Member

@PavelSBorisov PavelSBorisov commented Nov 25, 2024

Description:
This PR updates the slack-github-action to the newest major version https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0
Implements the new variable to allow templated payloads which were enabled by default in the previous version - https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0#only-one-payload-input-can-be-provided
Related issue(s):

Fixes #16749

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@PavelSBorisov PavelSBorisov added the github_actions Pull requests that update GitHub Actions code label Nov 25, 2024
@PavelSBorisov PavelSBorisov added this to the v0.58 milestone Nov 25, 2024
@PavelSBorisov PavelSBorisov self-assigned this Nov 25, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners November 25, 2024 14:53
@PavelSBorisov PavelSBorisov linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link

codacy-production bot commented Nov 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (65b085a) 97916 64095 65.46%
Head commit (f2d746b) 97916 (+0) 64095 (+0) 65.46% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16773) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.75%. Comparing base (65b085a) to head (f2d746b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16773   +/-   ##
==========================================
  Coverage      63.75%   63.75%           
  Complexity     20535    20535           
==========================================
  Files           2540     2540           
  Lines          95151    95151           
  Branches        9941     9941           
==========================================
  Hits           60668    60668           
  Misses         30866    30866           
  Partials        3617     3617           

Impacted file tree graph

@PavelSBorisov PavelSBorisov force-pushed the 16749-update-workflow-to-function-with-major-slack-version-roll branch from a31f710 to 4c00fc2 Compare November 26, 2024 07:36
@rbarkerSL
Copy link
Contributor

I ran a test against this branch on prepare-xts-candidate: https://github.com/hashgraph/hedera-services/actions/runs/12035146720

It failed because the incoming webhook isn't set correctly. I believe that it wants SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK to be SLACK_WEBHOOK_TYPE: 'incoming-webhook'

.github/workflows/node-zxc-build-release-artifact.yaml Outdated Show resolved Hide resolved
.github/workflows/node-zxcron-release-branching.yaml Outdated Show resolved Hide resolved
.github/workflows/zxcron-extended-test-suite.yaml Outdated Show resolved Hide resolved
.github/workflows/zxcron-promote-build-candidate.yaml Outdated Show resolved Hide resolved
.github/workflows/zxf-prepare-extended-test-suite.yaml Outdated Show resolved Hide resolved
@PavelSBorisov PavelSBorisov force-pushed the 16749-update-workflow-to-function-with-major-slack-version-roll branch 2 times, most recently from a64a868 to b0f46c4 Compare November 28, 2024 07:33
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
…rsion

Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
@PavelSBorisov PavelSBorisov force-pushed the 16749-update-workflow-to-function-with-major-slack-version-roll branch from b0f46c4 to 7adcde5 Compare November 28, 2024 09:06
@PavelSBorisov
Copy link
Member Author

I ran a test against this branch on prepare-xts-candidate: https://github.com/hashgraph/hedera-services/actions/runs/12035146720
It failed because the incoming webhook isn't set correctly. I believe that it wants SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK to be SLACK_WEBHOOK_TYPE: 'incoming-webhook'

Ran another test after fixing the above, result seems to be reported correctly now:
https://github.com/hashgraph/hedera-services/actions/runs/12067628115/job/33651001636

Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@PavelSBorisov PavelSBorisov merged commit 9d28048 into develop Dec 4, 2024
46 checks passed
@PavelSBorisov PavelSBorisov deleted the 16749-update-workflow-to-function-with-major-slack-version-roll branch December 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update workflow to function with major slack version roll
2 participants