-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump slackapi/slack-github-action from 1.25.0 to 2.0.0 #16773
build(deps): bump slackapi/slack-github-action from 1.25.0 to 2.0.0 #16773
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16773 +/- ##
==========================================
Coverage 63.75% 63.75%
Complexity 20535 20535
==========================================
Files 2540 2540
Lines 95151 95151
Branches 9941 9941
==========================================
Hits 60668 60668
Misses 30866 30866
Partials 3617 3617 |
a31f710
to
4c00fc2
Compare
I ran a test against this branch on prepare-xts-candidate: https://github.com/hashgraph/hedera-services/actions/runs/12035146720 It failed because the incoming webhook isn't set correctly. I believe that it wants |
a64a868
to
b0f46c4
Compare
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
…rsion Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
b0f46c4
to
7adcde5
Compare
Ran another test after fixing the above, result seems to be reported correctly now: |
…jor-slack-version-roll
…jor-slack-version-roll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
…jor-slack-version-roll
Description:
This PR updates the slack-github-action to the newest major version https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0
Implements the new variable to allow templated payloads which were enabled by default in the previous version - https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0#only-one-payload-input-can-be-provided
Related issue(s):
Fixes #16749
Notes for reviewer:
N/A
Checklist