-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace AddressBook
with Roster
in PlatformBuilder
#16732
chore: replace AddressBook
with Roster
in PlatformBuilder
#16732
Conversation
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16732 +/- ##
=============================================
+ Coverage 63.45% 63.65% +0.20%
- Complexity 20304 20449 +145
=============================================
Files 2544 2538 -6
Lines 94578 94926 +348
Branches 9875 9916 +41
=============================================
+ Hits 60012 60426 +414
+ Misses 30952 30887 -65
+ Partials 3614 3613 -1
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
…SwirldStateManager # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformBuilder.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/SwirldStateManagerTests.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/SwirldStateManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
...rm-core/src/test/java/com/swirlds/platform/eventhandling/DefaultTransactionHandlerTests.java
Outdated
Show resolved
Hide resolved
...rm-core/src/test/java/com/swirlds/platform/eventhandling/DefaultTransactionHandlerTests.java
Show resolved
Hide resolved
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Description:
This PR replaces the
AddressBook
withRoster
in thePlatformBuilder
Related issue(s):
Fixes #16728