Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace AddressBook with Roster in PlatformBuilder #16732

Conversation

edward-swirldslabs
Copy link
Contributor

Description:

This PR replaces the AddressBook with Roster in the PlatformBuilder

Related issue(s):

Fixes #16728

Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs added this to the v0.57 milestone Nov 22, 2024
@edward-swirldslabs edward-swirldslabs self-assigned this Nov 22, 2024
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner November 22, 2024 00:45
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (5a72bc9) to head (0c24196).
Report is 43 commits behind head on develop.

Files with missing lines Patch % Lines
.../com/swirlds/platform/builder/PlatformBuilder.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16732      +/-   ##
=============================================
+ Coverage      63.45%   63.65%   +0.20%     
- Complexity     20304    20449     +145     
=============================================
  Files           2544     2538       -6     
  Lines          94578    94926     +348     
  Branches        9875     9916      +41     
=============================================
+ Hits           60012    60426     +414     
+ Misses         30952    30887      -65     
+ Partials        3614     3613       -1     
Files with missing lines Coverage Δ
...lds/platform/gossip/DefaultIntakeEventCounter.java 80.00% <100.00%> (-0.96%) ⬇️
...com/swirlds/platform/state/SwirldStateManager.java 96.55% <100.00%> (ø)
...ava/com/swirlds/platform/uptime/UptimeMetrics.java 83.33% <100.00%> (-0.76%) ⬇️
...ava/com/swirlds/platform/uptime/UptimeTracker.java 96.38% <100.00%> (+0.08%) ⬆️
.../com/swirlds/platform/builder/PlatformBuilder.java 0.00% <0.00%> (ø)

... and 151 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 93.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5a72bc9) 97343 63437 65.17%
Head commit (0c24196) 97112 (-231) 63361 (-76) 65.25% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16732) 30 28 93.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

…SwirldStateManager

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformBuilder.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/SwirldStateManagerTests.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
lpetrovic05
lpetrovic05 previously approved these changes Nov 25, 2024
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs merged commit 83f1eac into develop Dec 3, 2024
49 of 50 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 16728-replace-addressbook-with-roster-in-SwirldStateManager branch December 3, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace AddressBook with Roster in PlatformBuilder and SwirldStateManager
3 participants