Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update gRPC component design doc #16709

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

MiroslavGatsanoga
Copy link
Collaborator

Description:

Adding more details to gRPC component design doc.

Related issue(s):

Fixes #16599

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.57 milestone Nov 21, 2024
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Nov 21, 2024
@MiroslavGatsanoga MiroslavGatsanoga requested a review from a team as a code owner November 21, 2024 14:11
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Copy link

codacy-production bot commented Nov 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1901fc3) 97954 64200 65.54%
Head commit (24210ff) 97954 (+0) 64200 (+0) 65.54% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16709) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (1901fc3) to head (24210ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16709   +/-   ##
==========================================
  Coverage      63.86%   63.86%           
  Complexity     20578    20578           
==========================================
  Files           2540     2540           
  Lines          95189    95189           
  Branches        9944     9944           
==========================================
  Hits           60795    60795           
  Misses         30799    30799           
  Partials        3595     3595           

Impacted file tree graph

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
iwsimon
iwsimon previously approved these changes Dec 4, 2024
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MiroslavGatsanoga

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @MiroslavGatsanoga

@MiroslavGatsanoga MiroslavGatsanoga merged commit 0b0cb4f into develop Dec 5, 2024
48 of 49 checks passed
@MiroslavGatsanoga MiroslavGatsanoga deleted the 16599-grpc-component-design-doc branch December 5, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update design doc for GRPC component
3 participants