-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update gRPC component design doc #16709
Conversation
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16709 +/- ##
==========================================
Coverage 63.86% 63.86%
Complexity 20578 20578
==========================================
Files 2540 2540
Lines 95189 95189
Branches 9944 9944
==========================================
Hits 60795 60795
Misses 30799 30799
Partials 3595 3595 |
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MiroslavGatsanoga
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @MiroslavGatsanoga
Description:
Adding more details to gRPC component design doc.
Related issue(s):
Fixes #16599
Notes for reviewer:
Checklist