Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: system transaction proto changes #16702

Merged
merged 14 commits into from
Dec 3, 2024

Conversation

mustafauzunn
Copy link
Collaborator

Description:

The idea is to clean the design of event transactions. Initially, we will support both repeated EventTransaction event_transaction and repeated bytes transaction in GossipEvent proto.

  1. Inside TransactionBody add a new proto type - StateSignatureTransactionBody
  2. Adapt GossipEvent proto to have repeated bytes transaction

Related issue(s):

Fixes #16675

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added the Platform Tickets pertaining to the platform label Nov 21, 2024
@mustafauzunn mustafauzunn self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (917ea25) to head (6ba1b95).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16702   +/-   ##
==========================================
  Coverage      63.65%   63.65%           
- Complexity     20449    20453    +4     
==========================================
  Files           2538     2538           
  Lines          94927    94929    +2     
  Branches        9919     9919           
==========================================
+ Hits           60425    60430    +5     
+ Misses         30887    30884    -3     
  Partials        3615     3615           
Files with missing lines Coverage Δ
...m/hedera/node/config/data/ApiPermissionConfig.java 100.00% <100.00%> (ø)
...java/com/swirlds/platform/event/PlatformEvent.java 83.18% <100.00%> (ø)
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 60.55% <0.00%> (-0.34%) ⬇️

... and 13 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (917ea25) 97692 63850 65.36%
Head commit (6ba1b95) 97694 (+2) 63855 (+5) 65.36% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16702) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added this to the v0.57 milestone Nov 21, 2024
@mustafauzunn mustafauzunn reopened this Nov 21, 2024
@mustafauzunn mustafauzunn marked this pull request as ready for review November 21, 2024 14:31
@mustafauzunn mustafauzunn requested review from a team and jsync-swirlds as code owners November 21, 2024 14:31
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggested adjustments to clarify the intent and purpose for these changed data structures.

hapi/hedera-protobufs/services/transaction_body.proto Outdated Show resolved Hide resolved
hapi/hedera-protobufs/platform/event/gossip_event.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/PlatformEvent.java

looks good to me.

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
lpetrovic05
lpetrovic05 previously approved these changes Nov 25, 2024
netopyr
netopyr previously approved these changes Nov 25, 2024
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @mustafauzunn

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…6675-system-transaction-refactoring-proto

# Conflicts:
#	hapi/hedera-protobufs/services/basic_types.proto
#	hapi/hedera-protobufs/services/transaction_body.proto
#	hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java
#	hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mustafauzunn mustafauzunn merged commit 5d218c7 into develop Dec 3, 2024
46 checks passed
@mustafauzunn mustafauzunn deleted the 16675-system-transaction-refactoring-proto branch December 3, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new proto types for system transaction refactoring
9 participants