-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: system transaction proto changes #16702
refactor: system transaction proto changes #16702
Conversation
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16702 +/- ##
==========================================
Coverage 63.65% 63.65%
- Complexity 20449 20453 +4
==========================================
Files 2538 2538
Lines 94927 94929 +2
Branches 9919 9919
==========================================
+ Hits 60425 60430 +5
+ Misses 30887 30884 -3
Partials 3615 3615
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some suggested adjustments to clarify the intent and purpose for these changed data structures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/PlatformEvent.java
looks good to me.
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…6675-system-transaction-refactoring-proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @mustafauzunn
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
f749c5e
…6675-system-transaction-refactoring-proto # Conflicts: # hapi/hedera-protobufs/services/basic_types.proto # hapi/hedera-protobufs/services/transaction_body.proto # hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description:
The idea is to clean the design of event transactions. Initially, we will support both
repeated EventTransaction event_transaction
andrepeated bytes transaction
in GossipEvent proto.StateSignatureTransactionBody
repeated bytes transaction
Related issue(s):
Fixes #16675
Notes for reviewer:
Checklist