Check all usages of getReadablePlatformState() for thread safety

[thenswan]

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Node: Unit Test Results

  1 617 files  ± 0        8 errors  1 609 suites   - 8   54m 58s ⏱️ - 4m 29s
125 271 tests  - 13  125 215 ✅  - 13  56 💤 ±0  0 ❌ ±0 
131 509 runs   - 27  131 453 ✅  - 27  56 💤 ±0  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit e076f4d. ± Comparison against base commit df149d7.

This pull request removes 768 and adds 532 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-node1
            SubjectDN: CN=s-node1
           Final Date: Fri Jan 01 00:00:00 GMT 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 GMT 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f…
        modulus: c1a0ff5d2372b53d12d12bb87dd03…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [10] INVALID_TRANSACTION_ID
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [11] INVALID_SIGNATURE
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [12] INSUFFICIENT_PAYER_BALANCE
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [13] KEY_REQUIRED
…

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (df149d7) to head (e076f4d).
Report is 12 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #16603   +/-   ##
==========================================
  Coverage      63.53%   63.54%           
- Complexity     20370    20373    +3     
==========================================
  Files           2537     2537           
  Lines          94746    94752    +6     
  Branches        9902     9903    +1     
==========================================
+ Hits           60198    60210   +12     
+ Misses         30941    30936    -5     
+ Partials        3607     3606    -1     

Files with missing lines	Coverage Δ
...wirlds/platform/state/PlatformMerkleStateRoot.java	78.43% <100.00%> (+0.88%)	⬆️
...com/swirlds/platform/state/SwirldStateManager.java	96.77% <100.00%> (+0.22%)	⬆️

... and 11 files with indirect coverage changes

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (df149d7)	97511	63616	65.24%
Head commit (e076f4d)	97517 (+6)	63627 (+11)	65.25% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#16603)	6	6	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}