-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Updating GitHub actions to use semantic versioning. #16598
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16598 +/- ##
=========================================
Coverage 67.30% 67.30%
Complexity 21996 21996
=========================================
Files 2582 2582
Lines 96248 96248
Branches 10055 10055
=========================================
Hits 64775 64775
Misses 27779 27779
Partials 3694 3694 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good! A few --very minor-- change requests and then it looks like we'll need to generate an NPM_TOKEN
c0338a4
to
4dd189d
Compare
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
4dd189d
to
f3856c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Has this been tested yet?
@andrewb1269hg @san-est
I have a meeting with Nathan and Roger tomorrow to chat about the appropriate testing process to ensure we test this adequately before merging it to the mainline. |
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
77f22da
to
d5b496a
Compare
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
This is a draft PR at this time. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
35836a8
to
0cd6036
Compare
Description:
This PR aims to update the release workflows to use semantic versioning. The changes that have been done are re-work of node-flow-deploy-release-artifact.yaml and node-zxc-build-release-artifact.yaml. I've also added .releaserc.json.
Related issue(s):
Fixes #14967
Fixes #11781
Notes for reviewer:
Checklist