Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve process hang visibility #16485

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners November 7, 2024 15:11
@tinker-michaelj tinker-michaelj added this to the v0.57 milestone Nov 7, 2024
@tinker-michaelj tinker-michaelj self-assigned this Nov 7, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (539105d) 96496 62809 65.09%
Head commit (e20fc12) 96496 (+0) 62809 (+0) 65.09% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16485) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.35%. Comparing base (539105d) to head (e20fc12).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16485   +/-   ##
==========================================
  Coverage      63.35%   63.35%           
- Complexity     20099    20100    +1     
==========================================
  Files           2527     2527           
  Lines          93677    93677           
  Branches        9804     9804           
==========================================
  Hits           59349    59349           
  Misses         30730    30730           
  Partials        3598     3598           

Impacted file tree graph

@tinker-michaelj tinker-michaelj merged commit 700e95e into develop Nov 7, 2024
53 of 61 checks passed
@tinker-michaelj tinker-michaelj deleted the 16478-process-hang-visibility branch November 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gain visibility into why subprocess ProcessHandle.destroy() is flaky
2 participants