-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move public.pfx
to correct subdirectory
#16444
fix: move public.pfx
to correct subdirectory
#16444
Conversation
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16444 +/- ##
==========================================
Coverage 63.35% 63.35%
- Complexity 20097 20099 +2
==========================================
Files 2527 2527
Lines 93677 93677
Branches 9804 9804
==========================================
+ Hits 59347 59349 +2
+ Misses 30731 30730 -1
+ Partials 3599 3598 -1
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
8b3fb34
to
5ec017b
Compare
.../swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/EnhancedKeyStoreLoader.java
Show resolved
Hide resolved
I believe you have an open PR to cherry pick the original change back into 56. Please remember this one as well. I'm assuming it's needed. |
Description:
When I implemented the migration, I used the wrong sub-directory for moving
public.pfx
to. This corrects the mistake to put the file in the dated sub-directory.Related issue(s):
Fixes #16439
Notes for reviewer:
I also fixed a bug in the Browser start which needed to add the cryptography to the address book in the call to GuiEventStorage.