Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move public.pfx to correct subdirectory #16444

Conversation

edward-swirldslabs
Copy link
Contributor

Description:

When I implemented the migration, I used the wrong sub-directory for moving public.pfx to. This corrects the mistake to put the file in the dated sub-directory.

Related issue(s):

Fixes #16439

Notes for reviewer:

I also fixed a bug in the Browser start which needed to add the cryptography to the address book in the call to GuiEventStorage.

Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs added this to the v0.57 milestone Nov 5, 2024
@edward-swirldslabs edward-swirldslabs self-assigned this Nov 5, 2024
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner November 5, 2024 21:49
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.35%. Comparing base (52a7fce) to head (b2db986).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16444   +/-   ##
==========================================
  Coverage      63.35%   63.35%           
- Complexity     20097    20099    +2     
==========================================
  Files           2527     2527           
  Lines          93677    93677           
  Branches        9804     9804           
==========================================
+ Hits           59347    59349    +2     
+ Misses         30731    30730    -1     
+ Partials        3599     3598    -1     
Files with missing lines Coverage Δ
...wirlds/platform/crypto/EnhancedKeyStoreLoader.java 69.68% <100.00%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (52a7fce) 96496 62808 65.09%
Head commit (b2db986) 96496 (+0) 62809 (+1) 65.09% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16444) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@poulok
Copy link
Member

poulok commented Nov 6, 2024

I believe you have an open PR to cherry pick the original change back into 56. Please remember this one as well. I'm assuming it's needed.

@edward-swirldslabs
Copy link
Contributor Author

edward-swirldslabs commented Nov 6, 2024

I believe you have an open PR to cherry pick the original change back into 56. Please remember this one as well. I'm assuming it's needed.

@poulok The cherry pick of this PR's commit is included in: #16457

@edward-swirldslabs edward-swirldslabs merged commit 539105d into develop Nov 6, 2024
49 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 16439-fix-migration-public-pfx-file-to-correct-directory branch November 6, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix cryptography migration of public.pfx file to correct subdirectory.
4 participants