Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implement RekeyScenarioOp #16407

Merged
merged 22 commits into from
Nov 5, 2024
Merged

chore: Implement RekeyScenarioOp #16407

merged 22 commits into from
Nov 5, 2024

Conversation

tinker-michaelj
Copy link
Collaborator

Neeharika-Sompalli and others added 9 commits November 4, 2024 11:25
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

codacy-production bot commented Nov 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 99.46%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (420eee2) 96373 62707 65.07%
Head commit (2a9da86) 96364 (-9) 62678 (-29) 65.04% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16407) 185 184 99.46%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Base automatically changed from 16119-enable-test-v1 to develop November 4, 2024 18:53
@Neeharika-Sompalli Neeharika-Sompalli requested a review from a team as a code owner November 4, 2024 18:53
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 98.91892% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.30%. Comparing base (420eee2) to head (2a9da86).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...app/workflows/handle/steps/StakePeriodChanges.java 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16407      +/-   ##
=============================================
- Coverage      63.32%   63.30%   -0.03%     
+ Complexity     20060    20057       -3     
=============================================
  Files           2523     2523              
  Lines          93554    93545       -9     
  Branches        9802     9798       -4     
=============================================
- Hits           59244    59217      -27     
- Misses         30709    30729      +20     
+ Partials        3601     3599       -2     
Files with missing lines Coverage Δ
...ervice/addressbook/impl/ReadableNodeStoreImpl.java 100.00% <ø> (ø)
...ode/app/service/addressbook/ReadableNodeStore.java 0.00% <ø> (ø)
...a/com/hedera/node/app/info/GenesisNetworkInfo.java 75.00% <100.00%> (ø)
...ava/com/hedera/node/app/info/StateNetworkInfo.java 69.69% <ø> (ø)
...va/com/hedera/node/app/tss/TssBaseServiceImpl.java 62.50% <100.00%> (+0.68%) ⬆️
...om/hedera/node/app/tss/TssCryptographyManager.java 100.00% <100.00%> (ø)
...edera/node/app/tss/handlers/TssMessageHandler.java 100.00% <100.00%> (ø)
...ava/com/hedera/node/app/tss/handlers/TssUtils.java 97.56% <100.00%> (+0.26%) ⬆️
...dera/node/app/workflows/handle/HandleWorkflow.java 82.30% <100.00%> (ø)
...pl/handlers/staking/EndOfStakingPeriodUpdater.java 100.00% <100.00%> (ø)
... and 4 more

... and 19 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested a review from a team as a code owner November 4, 2024 21:59
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
jeromy-cannon
jeromy-cannon previously approved these changes Nov 5, 2024
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to:

  • hedera-node/test-clients/build.gradle.kts
  • hedera-node/test-clients/src/main/java/module-info.java

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes are making the code more readable. Thanks for the comments in the staking code.
LGTM! Thanks @tinker-michaelj

@tinker-michaelj tinker-michaelj merged commit 774f08a into develop Nov 5, 2024
49 of 50 checks passed
@tinker-michaelj tinker-michaelj deleted the 16309-tss-txn-sim branch November 5, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add embedded @HapiTest support for simulating TSS transactions from other nodes
5 participants