-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implements HIP-632 isAuthorized
method
#16364
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16364 +/- ##
=============================================
+ Coverage 63.36% 63.38% +0.02%
- Complexity 20081 20099 +18
=============================================
Files 2524 2526 +2
Lines 93590 93655 +65
Branches 9801 9808 +7
=============================================
+ Hits 59301 59366 +65
Misses 30689 30689
Partials 3600 3600
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Fixes #16092 Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
... and fix up 'isAuthorizedRaw' BDDs that failed due to an (undetermined) gas change Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
939146d
to
8f17af3
Compare
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
.../java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/has/HasCallAttempt.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/has/isauthorizedraw/IsAuthorizedRawCall.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/has/isauthorized/IsAuthorizedTranslator.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/has/isauthorized/IsAuthorizedTranslator.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/has/isauthorized/IsAuthorizedTranslator.java
Show resolved
Hide resolved
...a/node/app/service/contract/impl/exec/systemcontracts/has/isauthorized/IsAuthorizedCall.java
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/utilops/UtilVerbs.java
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/utils/Signing.java
Show resolved
Hide resolved
...-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip632/IsAuthorizedTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some comments for future cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description:
Implements
isAuthorized
method of HIP-632.(Better PR description forthcoming.)
Related issue(s):
Fixes #16092
Notes for reviewer:
Adding a constructor argument to
HasCallAttempt
- theSignatureVerifier
- had effects on a lot of unrelated unit tests. Because: A new argument had to be mocked and supplied to all instantiations of that class. But in nearly all cases 5 of the 7 arguments are simply passing in mocks, which mostly don't even have givens). So the next time we add an argument to such a constructor maybe we could refactor all those calls ... or do it as a cleanup sometime sooner just in case...Checklist