feat: always generate agreement key on startup #16315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR stops reading the agreement key from disk and always generates it on startup. The migration code will delete the agreement key if found and force generation anyway. This is a code cleanup operation so that when the migration code is removed, there are no potential bugs.
Potential Bug This Avoids:
Fixes #16161
Notes for reviewer:
The only testing required and performed was unit testing. The special casing on one of the negative unit tests was removed because we are no longer reading a valid agreement key in that scenario.