Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: HIP-796: Add token lock, partition, move keys (Services) #16313

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

thomas-swirlds-labs
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs commented Oct 30, 2024

Description:

Addition of lock_key , partition_key and partition_move_key definition to Protobufs in support of HIP-796

Related issue(s):

Fixes #16310

Reviewer Notes
Note this PR is only for adding values to this query and unblock dev work on feature branch

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
@thomas-swirlds-labs thomas-swirlds-labs added this to the v0.57 milestone Oct 30, 2024
@thomas-swirlds-labs thomas-swirlds-labs self-assigned this Oct 30, 2024
Copy link

codacy-production bot commented Oct 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fa9c73f) 96198 62107 64.56%
Head commit (1ebb486) 96198 (+0) 62105 (-2) 64.56% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16313) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.82%. Comparing base (fa9c73f) to head (1ebb486).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16313   +/-   ##
==========================================
  Coverage      62.82%   62.82%           
+ Complexity     19924    19922    -2     
==========================================
  Files           2524     2524           
  Lines          93379    93379           
  Branches        9804     9804           
==========================================
+ Hits           58667    58668    +1     
- Misses         31134    31136    +2     
+ Partials        3578     3575    -3     

see 7 files with indirect coverage changes

Impacted file tree graph

Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about the intended scope of this PR, and
A mild recommendation for the specification text

hapi/hedera-protobufs/services/token_get_info.proto Outdated Show resolved Hide resolved
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Copy link

github-actions bot commented Nov 1, 2024

Node: HAPI Test (Restart) Results

6 tests   1 ✅  2m 26s ⏱️
7 suites  0 💤
9 files    5 ❌
2 errors

For more details on these parsing errors and failures, see this check.

Results for commit 6256c0d.

♻️ This comment has been updated with latest results.

@thomas-swirlds-labs thomas-swirlds-labs merged commit 789e153 into develop Nov 4, 2024
50 checks passed
@thomas-swirlds-labs thomas-swirlds-labs deleted the 9636-hip796-proto-key-definitions branch November 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add HIP-796 Protobuf Key Definitions
2 participants