-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: HIP-796: Add token lock, partition, move keys (Services) #16313
chore: HIP-796: Add token lock, partition, move keys (Services) #16313
Conversation
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16313 +/- ##
==========================================
Coverage 62.82% 62.82%
+ Complexity 19924 19922 -2
==========================================
Files 2524 2524
Lines 93379 93379
Branches 9804 9804
==========================================
+ Hits 58667 58668 +1
- Misses 31134 31136 +2
+ Partials 3578 3575 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about the intended scope of this PR, and
A mild recommendation for the specification text
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Node: HAPI Test (Restart) Results6 tests 1 ✅ 2m 26s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 6256c0d. ♻️ This comment has been updated with latest results. |
Description:
Addition of lock_key , partition_key and partition_move_key definition to Protobufs in support of HIP-796
Related issue(s):
Fixes #16310
Reviewer Notes
Note this PR is only for adding values to this query and unblock dev work on feature branch