Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updating workflow to skip codacy checks on forked PRs. #16215

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Oct 29, 2024

Description:
This a recreation of PR #16078
Codecy reporter needs additional parameters to be skipped on forked PRs so that steps/actions which require the use of secrets are only ran on PRs from the original repo.

Related issue(s):

Fixes #14293

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@san-est san-est added the github_actions Pull requests that update GitHub Actions code label Oct 29, 2024
@san-est san-est added this to the v0.57 milestone Oct 29, 2024
@san-est san-est self-assigned this Oct 29, 2024
@san-est san-est requested review from a team as code owners October 29, 2024 09:42
@san-est san-est requested a review from dalvizu October 29, 2024 09:42
Copy link

codacy-production bot commented Oct 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e178e9f) 100156 62038 61.94%
Head commit (314ecc8) 100156 (+0) 62038 (+0) 61.94% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16215) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (e178e9f) to head (314ecc8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16215   +/-   ##
==========================================
  Coverage      58.35%   58.35%           
  Complexity     19975    19975           
==========================================
  Files           2735     2735           
  Lines         100339   100339           
  Branches       10365    10365           
==========================================
  Hits           58548    58548           
  Misses         38164    38164           
  Partials        3627     3627           

Impacted file tree graph

@rbarkerSL rbarkerSL requested review from andrewb1269hg and removed request for dalvizu October 29, 2024 13:39
@san-est san-est force-pushed the 14293-skip_codacy_checks branch from 90c762f to ae1fed0 Compare October 30, 2024 07:31
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
@san-est san-est force-pushed the 14293-skip_codacy_checks branch from ae1fed0 to 314ecc8 Compare October 30, 2024 09:17
@san-est san-est merged commit 593a623 into develop Oct 30, 2024
49 checks passed
@san-est san-est deleted the 14293-skip_codacy_checks branch October 30, 2024 10:39
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Codacy Checks on Forked PRs
2 participants